145815 - Implement Search (button that loads search.netscape.com)

Status: VERIFIED FIXED

(Camino Graveyard :: General, defect)

Description

[Winnie Lam]

Implement Search ( button that loads search.netscape.com).

Comment 1

[Greg K.]

I presume this will be user-settable to other search engines as is the case in
Mozilla...

Comment 2

[Steve Smart]

Should probably respect the System Preferences search page, as Chimera already
respects the home page from there?

Comment 3

[saari (gone)]

->beard

Comment 4

[Steve Smart]

This has been implemented, although right now the button can only take you to
dmoz.org. Also, I saw in the CVS notes that Beard didn't have an icon for this
so he used the magnifying glass from the finder. We already have a Chimera-style
magnifying glass in the file download window's toolbar that we could use for
this. Since that window is going to be replaced, we don't have to worry about
using the same icon for two different things.

This could now be changed to an RFE to have the search button be customizable. I
noticed that there is an unimplemented drop down menu to change search engines
in the personal pref pane, but I would think we could just use the search page
from system prefs?

Comment 5

[Brian Nesse (gone)]

Taking this back so I can find it more easily. :)

Comment 6

[Brian Nesse (gone)]

Attachment: Proposed patch

Patch to replace search image and connect the button to the users Internet
Config setting for search page.

Mike, Patrick, can one of you review this and check it in if it's ok? Thanks.

Comment 7

[Brian Nesse (gone)]

Really take it back...

Comment 8

[Brian Nesse (gone)]

Attachment: Revised patch

Revised patch according to branding requirements. Mike, can you r= and land?

Comment 9

[Mike Pinkerton (not reading bugmail)]

no, we should be reading this from a localized string that any commercial build
can replace. no netscape branding is allowed in the mozilla tree.

Comment 10

[Brian Nesse (gone)]

Attachment: Yet another attempt

Here is a totally new approach. This allows us to force the search preference
by setting a preference in all.js

pref("search.default_engine","http://search.netscape.com/");

If this preference does not exist, we use the setting in InternetConfig.

Mike, it's in your court again. :)

Comment 11

[saari (gone)]

cc'ing sfraser for review, since pink has probably gone home

Comment 12

[Simon Fraser [no longer active]]

In most places in the code, instead of:

+    nsCOMPtr<nsIPrefService>
prefs(do_GetService("@mozilla.org/preferences-service;1"));
+    if (prefs) {
+        nsCOMPtr<nsIPrefBranch> dirBranch;
+        prefs->GetBranch("", getter_AddRefs(dirBranch));


we just do

nsCOMPtr<nsIPrefBranch> prefs = do_GetService("@mozilla.org/preferences-service;1");

Why not here?

Comment 13

[Brian Nesse (gone)]

Attachment: Patch v4

Version reflecting sfraser's comments.

Comment 14

[Simon Fraser [no longer active]]

Comment on attachment 89630 [details] [diff] [review]
Patch v4

r=sfraser

Comment 15

[Brian Nesse (gone)]

Simon, do you have checkin privileges for chimera? If so, can you land this?
Otherwise, Chris, who else can land this?

Comment 16

[Simon Fraser [no longer active]]

I do, and I can.

Comment 17

[Simon Fraser [no longer active]]

Checked in for bnesse.

Comment 18

[Winnie Lam]

verified with 07-02 build on OS 10.1.5.  clicking on the search button takes me
to the search.netscape.com page.