Closed
Bug 1458398
Opened 6 years ago
Closed 6 years ago
Typo in LICENSE URL
Categories
(Toolkit :: Telemetry, defect, P3)
Tracking
()
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: is2ei, Assigned: is2ei, Mentored)
Details
(Whiteboard: [good first bug])
Attachments
(1 file, 1 obsolete file)
1.55 KB,
patch
|
janerik
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:59.0) Gecko/20100101 Firefox/59.0 Build ID: 20180326160923 Steps to reproduce: Read source code. Actual results: Type in these files. - toolkit/components/telemetry/tests/python/test_histogramtools_non_strict.py - toolkit/components/telemetry/tests/python/test_histogramtools_non_strict.py Typo is " # file, You can obtain one at http://mozilla.org/MPL/2.0/.import json". https://searchfox.org/mozilla-central/search?q=MPL%2F2.0%2F.import+json&case=true®exp=false&path= Expected results: Typo needs to be fixed.
Updated•6 years ago
|
Component: Untriaged → Telemetry
Product: Firefox → Toolkit
Updated•6 years ago
|
Mentor: jrediger
Whiteboard: [good first bug]
Assignee | ||
Comment 1•6 years ago
|
||
Hi, I'm Issei. Could I work on this issue?
Flags: needinfo?(jrediger)
Comment 2•6 years ago
|
||
@Issei: Yes, please work on this. As you reported this I guess you already know what to do.
Flags: needinfo?(jrediger)
Updated•6 years ago
|
Assignee: nobody → is2ei.horie
Updated•6 years ago
|
Priority: -- → P3
Assignee | ||
Comment 3•6 years ago
|
||
I attached a patch. Could you review it?
Attachment #8972607 -
Flags: review?(jrediger)
Comment 4•6 years ago
|
||
That looks good. Can you do me the favor and change the commit messages to describe what was done, e.g. "Fix typo in License URL"?
Flags: needinfo?(is2ei.horie)
Updated•6 years ago
|
Attachment #8972607 -
Flags: review?(jrediger) → review-
Assignee | ||
Comment 5•6 years ago
|
||
Thanks! I've edited the comment. Could you check it, please? Thanks.
Flags: needinfo?(is2ei.horie)
Attachment #8972744 -
Flags: review?(jrediger)
Updated•6 years ago
|
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Updated•6 years ago
|
Attachment #8972744 -
Flags: review?(jrediger) → review+
Updated•6 years ago
|
Attachment #8972607 -
Attachment is obsolete: true
Pushed by ccoroiu@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/9fa0acb5980e Fix typo in License URL r=janerik
Keywords: checkin-needed
Comment 8•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/9fa0acb5980e
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•