1458584 - Remove the scrollbox-base binding and instead import the scrollbox.css file in components.css

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, task, P1)

Description

[Brian Grinstead [:bgrins]]

The scrollbar-base binding only loads a stylesheet. It's a pretty simple sheet, mostly used to set -moz-appearance and images: https://searchfox.org/mozilla-central/search?q=scrollbox.css&redirect=true.

This could be imported into components.css and the binding could be removed: https://dxr.mozilla.org/mozilla-central/rev/d2a4720d1c334b64d88a51678758c27ba8f03c89/toolkit/content/widgets/scrollbox.xml#12-16.

Any binding currently inheriting from it could directly inherit from basecontrol instead. Or even better, could stop inheriting from anything depending on if we rely on them being basecontrols.

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Triage: code cleanup.

Comment 2

[:Paolo Amadini]

Attachment: Bug 1458584 - Remove the scrollbox-base binding and instead import the scrollbox.css file in components.css.

Review commit: https://reviewboard.mozilla.org/r/245450/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/245450/

Comment 3

[Brian Grinstead [:bgrins]]

Comment on attachment 8979221 [details]
Bug 1458584 - Remove the scrollbox-base binding and instead import the scrollbox.css file in components.css.

https://reviewboard.mozilla.org/r/245450/#review251450

Thanks!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/13ae2716c71e
Remove the scrollbox-base binding and instead import the scrollbox.css file in components.css. r=bgrins

Comment 5

[Narcis Beleuzu [:NarcisB]]

Backed out for mochitest chrome failures on toolkit/content/tests/chrome/test_arrowpanel.xul.

Push: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=4d511f7fc5b5c16fdfea91242dea6086cd57c8c3
Backout: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=116bf80e887145e918be4de6c6a11bad885c7d96
Log link: https://treeherder.mozilla.org/logviewer.html#?job_id=179598640&repo=mozilla-inbound&lineNumber=4924

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f2fc440dae2c
Remove the scrollbox-base binding and instead import the scrollbox.css file in components.css. r=bgrins

Comment 7

[:Paolo Amadini]

Re-landed since this is unrelated to the failing test.

Comment 8

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/f2fc440dae2c