Closed
Bug 1458961
Opened 6 years ago
Closed 6 years ago
Land self-hosted assertion that previously caused CGC test failures
Categories
(Core :: JavaScript Engine, enhancement, P2)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla61
| Tracking | Status | |
|---|---|---|
| firefox61 | --- | fixed |
People
(Reporter: jonco, Assigned: jonco)
Details
Attachments
(1 file)
|
984 bytes,
patch
|
anba
:
review+
|
Details | Diff | Splinter Review |
In bug 1440309 an assertion in self-hosted code was left out of the final patch because it caused CGC tests to fail. I don't know why this happened but it doesn't happen any more.
|
Assignee | |
Comment 1•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7e44cdda337db960cac5d8f4d726f1436e67c4d1&group_state=expanded
|
|
Assignee | |
Comment 2•6 years ago
|
||
Attachment #8972949 -
Flags: review?(andrebargull)
|
||
Comment 3•6 years ago
|
||
Comment on attachment 8972949 [details] [diff] [review] bug1458961-land-string-assertion Review of attachment 8972949 [details] [diff] [review]: ----------------------------------------------------------------- Thanks!
Attachment #8972949 -
Flags: review?(andrebargull) → review+
|
||
Updated•6 years ago
|
Priority: -- → P2
Pushed by jcoppeard@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/6262a4f457d1 Re-add removed assertion to String_pad r=anba
|
||
Comment 5•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/6262a4f457d1
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•