1459111 - Rename ServoCSSParsingEnvironment and related functions to ParsingEnvironment.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P3)

Description

[Emilio Cobos Álvarez (:emilio)]

Servo is the only style system now, so no point in explicitly mention it.

Comment 1

[bobslept]

Attachment: 1459111-rename-servocssparsingenvironment.patch

Alright I hope this patch is correct. I have renamed ServoCSSParsingEnvironment to ParsingEnvironment, including some related functions. It builds and runs alright. Also passing |./mach mochitest -f browser layout/style/test/|.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Patch looks great, thank you! You need to request someone for review (I can be that someone if you want), using the r? flag in the "details" section of the attachment.

Meanwhile, I've pushed it to our CI in https://treeherder.mozilla.org/#/jobs?repo=try&revision=a8b0cd0ac142bf0d29a233d0b0ea77cd005d5c7b.

Thanks for the patch!

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 8975530 [details] [diff] [review]
1459111-rename-servocssparsingenvironment.patch

Review of attachment 8975530 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! Looks great to me!

Since you presumably don't have commit access yet you need to either put the checkin-needed keyword on the bug, or I can push it for you, whatever you prefer.

Comment 4

[bobslept]

Great work. You are right on the commit access part. Please push that beauty for me.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5c258f15c012
Rename ServoCSSParsingEnvironment to ParsingEnvironment. r=emilio

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/5c258f15c012