1460466 - Phab bot does not create r+ for acceptance when there are still blocking reviewers

Status: RESOLVED FIXED

(Conduit :: Phabricator, defect)

Description

[Steven MacLeod [:smacleod]]

If a reviewer accepts a revision while there are still other blocking reviewers, their acceptance will not be reflected on the attachment as an r+. If the blocking reviewer eventually accepts both users will then have a corresponding r_ created.

The r+ for the first reviewer should be created immediately.

For an example, see:
https://phabricator.services.mozilla.com/D1136#25721 (Initial reviewer acceptance)
https://phabricator.services.mozilla.com/D1136#25869 (Later blocking reviewer acceptance)
Bug 1459199 Comment 2 (r+ for both users)

Comment 1

[David Lawrence [:dkl]]

This is due to:
https://github.com/mozilla-bteam/bmo/blob/master/extensions/PhabBugz/lib/Feed.pm#L415

Currently the code skips adding r+ flags for a revision is set to 'needs-review' or 'changes-planned' so Phabricator does not set the status to 'accepted' until all blocking reviewers have accepted the revision.

I would need to just remove the revision status check and just record the acceptance status of each reviewer. Will create a PR with this change.

dkl

Comment 2

[David Lawrence [:dkl]]

Attachment: github pr #574