Closed
Bug 1460906
Opened 6 years ago
Closed 6 years ago
release_eta should not default to 'null', but an empty string.
Categories
(Release Engineering :: Release Automation: Other, defect)
Release Engineering
Release Automation: Other
Tracking
(firefox61 fixed, firefox62 fixed)
RESOLVED
FIXED
People
(Reporter: sfraser, Assigned: sfraser)
References
Details
(Keywords: regression)
Attachments
(2 files)
+++ This bug was initially created as a clone of Bug #1458854 +++ Updating release_eta for this one condition has caused it to treat the 'null' value specially in the parameters. It should default to ''
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → sfraser
Comment hidden (mozreview-request) |
Assignee | ||
Updated•6 years ago
|
Attachment #8975073 -
Flags: review?(aki)
Comment 2•6 years ago
|
||
mozreview-review |
Comment on attachment 8975073 [details] Bug 1460906 Fix use of config.params and release_eta https://reviewboard.mozilla.org/r/243416/#review249290 I think this works. Ideally we fix https://hg.mozilla.org/build/tools/file/tip/buildfarm/release/release-runner3.py#l211 to .get('release_eta', '') as well.
Attachment #8975073 -
Flags: review?(aki) → review+
Updated•6 years ago
|
Whiteboard: [checkin-needed-beta]
Pushed by sfraser@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fc4f2d0a1dfb Fix use of config.params and release_eta r=aki
Comment 4•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/fc4f2d0a1dfb
Comment 5•6 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/bcdf3ae5f22d
status-firefox61:
--- → fixed
Whiteboard: [checkin-needed-beta]
Comment 6•6 years ago
|
||
Attachment #8975853 -
Flags: review?(rail)
Updated•6 years ago
|
Attachment #8975853 -
Flags: review?(rail) → review+
You need to log in
before you can comment on or make changes to this bug.
Description
•