Closed
Bug 1461964
Opened 6 years ago
Closed 6 years ago
remove old osx 10.6 references in manifest files
Categories
(Core :: DMD, enhancement)
Tracking
()
RESOLVED
FIXED
mozilla62
| Tracking | Status | |
|---|---|---|
| firefox62 | --- | fixed |
People
(Reporter: jmaher, Assigned: apavel)
References
Details
(Whiteboard: [manifest_cleanup])
Attachments
(1 file, 1 obsolete file)
|
622 bytes,
patch
|
n.nethercote
:
review+
|
Details | Diff | Splinter Review |
we run our automation on osx 10.10, not 10.6 anymore. We can remove references to 10.6. there is one reference to osx 10.6 in here: https://searchfox.org/mozilla-central/source/memory/replace/dmd/test/xpcshell.ini#35
|
Assignee | |
Comment 1•6 years ago
|
||
Assignee: nobody → apavel
Attachment #8978822 -
Flags: review?(gbrown)
|
||
Comment 2•6 years ago
|
||
Comment on attachment 8978822 [details] [diff] [review] Removed osx reference Review of attachment 8978822 [details] [diff] [review]: ----------------------------------------------------------------- ::: memory/replace/dmd/test/xpcshell.ini @@ +32,1 @@ > # Bug 1077230 explains why this test is disabled on Mac 10.6. Please remove this comment. @@ +32,4 @@ > # Bug 1077230 explains why this test is disabled on Mac 10.6. > [test_dmd.js] > dmd = true > +skip-if = !(os=='linux' || os=='win') This isn't right. I believe you want this: > skip-if = !(os=='linux' || os=='win' || os=='mac') because `os_version!='10.6'` is now equivalent to `true`. ::: toolkit/components/telemetry/tests/unit/xpcshell.ini @@ -1,2 @@ > -[DEFAULT] > -head = head.js I don't know anything about telemetry tests, but deleting this entire file doesn't seem right.
|
|
Assignee | |
Comment 3•6 years ago
|
||
:njn thank you. done the modifications you mentioned, however, i'm not sure about
::: toolkit/components/telemetry/tests/unit/xpcshell.ini
@@ -1,2 @@
> -[DEFAULT]
> -head = head.js
i did not touch that file.
Attachment #8978822 -
Attachment is obsolete: true
Attachment #8978822 -
Flags: review?(gbrown)
Attachment #8979157 -
Flags: review?(n.nethercote)
|
|
||
Updated•6 years ago
|
Attachment #8979157 -
Flags: review?(n.nethercote) → review+
|
|
Assignee | |
Updated•6 years ago
|
Keywords: checkin-needed
Pushed by apavel@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/1a3b9492f30d removed mac 10.6 reference r=njn
Keywords: checkin-needed
|
||
Comment 5•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/1a3b9492f30d
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in
before you can comment on or make changes to this bug.
Description
•