Closed
Bug 1461975
Opened 6 years ago
Closed 6 years ago
remove old osx 10.6 references in manifest files
Categories
(Core :: Audio/Video: Playback, enhancement, P3)
Tracking
()
RESOLVED
FIXED
mozilla62
Tracking | Status | |
---|---|---|
firefox62 | --- | fixed |
People
(Reporter: jmaher, Assigned: nataliaCs)
References
Details
(Whiteboard: [manifest_cleanup])
Attachments
(2 files, 2 obsolete files)
1.28 KB,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
1.29 KB,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
we run our test automation on osx 10.10. We have old references to 10.6, 10.8, etc. in our manifest files. we can remove: https://searchfox.org/mozilla-central/source/testing/web-platform/meta/webvtt/rendering/cues-with-video/processing-model/dom_override_cue_text_while_paused.html.ini#6 ^ and in that file we can remove win 5.1.* and linux 12.04 * in addition there is another file with similar conditions to be removed: https://searchfox.org/mozilla-central/source/testing/web-platform/meta/webvtt/rendering/cues-with-video/processing-model/dom_override_remove_cue_while_paused.html.ini#8
Updated•6 years ago
|
Priority: -- → P3
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → ncsoregi
Assignee | ||
Comment 1•6 years ago
|
||
Attachment #8979762 -
Flags: review?(jmaher)
Assignee | ||
Comment 2•6 years ago
|
||
Attachment #8979763 -
Flags: review?(jmaher)
Assignee | ||
Comment 3•6 years ago
|
||
(In reply to Natalia Csoregi [:nataliaCs] from comment #2) > Created attachment 8979763 [details] [diff] [review] > bug1461975_remove_cue.patch I was not sure which one is the current version for Win, so I left ""if not debug and (os == "win") and (version == "6.2.9200") "" untouched (according to my friend wiki, 6.1 and newer are the current ones).
Comment 4•6 years ago
|
||
Comment on attachment 8979762 [details] [diff] [review] bug1461975_cue_text.patch Review of attachment 8979762 [details] [diff] [review]: ----------------------------------------------------------------- ::: testing/web-platform/meta/webvtt/rendering/cues-with-video/processing-model/dom_override_cue_text_while_paused.html.ini @@ +3,4 @@ > refurl: /webvtt/rendering/cues-with-video/processing-model/dom_override_cue_text_while_paused-ref.html > disabled: https://bugzilla.mozilla.org/show_bug.cgi?id=1018936 > expected: > + TIMEOUT Line indentation changed by 1 space. Please keep that unchanged.
Assignee | ||
Comment 5•6 years ago
|
||
(In reply to Sebastian Hengst [:aryx][:archaeopteryx] (needinfo on intermittent or backout) from comment #4) > Comment on attachment 8979762 [details] [diff] [review] > bug1461975_cue_text.patch > > Review of attachment 8979762 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: > testing/web-platform/meta/webvtt/rendering/cues-with-video/processing-model/ > dom_override_cue_text_while_paused.html.ini > @@ +3,4 @@ > > refurl: /webvtt/rendering/cues-with-video/processing-model/dom_override_cue_text_while_paused-ref.html > > disabled: https://bugzilla.mozilla.org/show_bug.cgi?id=1018936 > > expected: > > + TIMEOUT > > Line indentation changed by 1 space. Please keep that unchanged. sorry about that, doing it again rn
Assignee | ||
Comment 6•6 years ago
|
||
Attachment #8979762 -
Attachment is obsolete: true
Attachment #8979762 -
Flags: review?(jmaher)
Attachment #8979767 -
Flags: review?(jmaher)
Reporter | ||
Comment 7•6 years ago
|
||
Comment on attachment 8979763 [details] [diff] [review] bug1461975_remove_cue.patch Review of attachment 8979763 [details] [diff] [review]: ----------------------------------------------------------------- ::: testing/web-platform/meta/webvtt/rendering/cues-with-video/processing-model/dom_override_remove_cue_while_paused.html.ini @@ +4,3 @@ > disabled: https://bugzilla.mozilla.org/show_bug.cgi?id=1018936 > expected: > if not debug and (os == "win") and (version == "6.2.9200") and (processor == "x86_64") and (bits == 64): FAIL this is great. Technically we do not run 6.2.9200 anymore (that is windows 8), so you could remove line 6 as well. We can clean this up later. Your choice if you want to redo this patch.
Attachment #8979763 -
Flags: review?(jmaher) → review+
Reporter | ||
Comment 8•6 years ago
|
||
Comment on attachment 8979767 [details] [diff] [review] bug1461975_cue_text.patch Review of attachment 8979767 [details] [diff] [review]: ----------------------------------------------------------------- thanks!
Attachment #8979767 -
Flags: review?(jmaher) → review+
Reporter | ||
Updated•6 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 9•6 years ago
|
||
Attachment #8979763 -
Attachment is obsolete: true
Attachment #8979770 -
Flags: review?(jmaher)
Reporter | ||
Comment 10•6 years ago
|
||
Comment on attachment 8979770 [details] [diff] [review] bug1461975_remove_cue.patch Review of attachment 8979770 [details] [diff] [review]: ----------------------------------------------------------------- excellent
Attachment #8979770 -
Flags: review?(jmaher) → review+
Comment 11•6 years ago
|
||
Pushed by ncsoregi@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/9869fefc342c Removed old references to OSX10, Win5.1 and Linux12.04 on dom_override_cue_text_while_paused.html.ini. r=jmaher https://hg.mozilla.org/integration/mozilla-inbound/rev/94510eda31d4 Removed old references for OSX10.6 and Win5.1,6.2 on dom_override_remove_cue_while_paused.html.ini. r=jmaher
Keywords: checkin-needed
Comment 12•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/9869fefc342c https://hg.mozilla.org/mozilla-central/rev/94510eda31d4
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in
before you can comment on or make changes to this bug.
Description
•