1462662 - Wipe the container for privacy.usercontext.about_newtab_segregation.enabled on shutdown

Status: RESOLVED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

+++ This bug was initially created as a clone of Bug #1457929 +++

As discussed in Bug 1457929 - we should clear out the container used by privacy.usercontext.about_newtab_segregation.enabled (which I believe is '5') so we don't make a persistent container that tracks the user through thumbnails.

:baku proposed doing it on shutdown (and startup in case of crash.)

Comment 1

[Andrea Marchesini [:baku]]

Attachment: container_5.patch

This should be enough to cleanup the container number 5.

Comment 2

[Johann Hofmann [:johannh]]

Comment on attachment 8979530 [details] [diff] [review]
container_5.patch

Review of attachment 8979530 [details] [diff] [review]:
-----------------------------------------------------------------

As mentioned on IRC, I think we'll have to find a different solution for this because pending sanitization is currently only set when the user has chosen to clear data on shutdown.

Comment 3

[Andrea Marchesini [:baku]]

Attachment: container_5.patch

Comment 4

[Andrea Marchesini [:baku]]

Attachment: container_5.patch

Comment 5

[Johann Hofmann [:johannh]]

Comment on attachment 8981387 [details] [diff] [review]
container_5.patch

Review of attachment 8981387 [details] [diff] [review]:
-----------------------------------------------------------------

This should work, thanks!

::: browser/modules/Sanitizer.jsm
@@ +59,5 @@
>     */
>    PREF_TIMESPAN: "privacy.sanitize.timeSpan",
>  
>    /**
> +   * Pref to newTab segretation

spelling: segregation

You might also want to explain why that pref is here.

::: browser/modules/test/unit/test_Sanitizer_interrupted.js
@@ +11,5 @@
>  
>  add_task(async function() {
>    ChromeUtils.import("resource:///modules/Sanitizer.jsm");
> +
> +  Services.prefs.setBoolPref(Sanitizer.PREF_NEWTAB_SEGREGATION, false);

You need to clear this pref as well.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/62ed84f80e37
Wipe the container for privacy.usercontext.about_newtab_segregation.enabled on shutdown, r=johannh

Comment 7

[Cosmin Sabou [:CosminS]]

Backed out changeset for mochitest browser chrome failures on browser_startup.js

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&tochange=385a43483f1e06dc862c1aa159f41d0f3fac3fb7&fromchange=62ed84f80e377811d9e371b94c06243626aec230&filter-searchStr=browser%20chrome&filter-failure_classification_id=2&selectedJob=180742579

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=180742579&repo=mozilla-inbound&lineNumber=1994

Backout link: https://hg.mozilla.org/integration/mozilla-inbound/rev/385a43483f1e06dc862c1aa159f41d0f3fac3fb7

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7e62b8b3202a
Wipe the container for privacy.usercontext.about_newtab_segregation.enabled on shutdown, r=johannh

Comment 9

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/7e62b8b3202a

Comment 10

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Comment on attachment 8981387 [details] [diff] [review]
container_5.patch

[Feature/Bug causing the regression]: If Bug 1457929 is taken in beta, we should take this patch too.

[User impact if declined]: None; unless Bug 1457929 is taken in which case we'll have a weird (but not dangerous) situation for a release.

[Is this code covered by automated tests?]: Yes

[Has the fix been verified in Nightly?]: Yes

[Needs manual test from QE? If yes, steps to reproduce]: No

[List of other uplifts needed for the feature/fix]: Only needed if we take Bug 1457929

[Is the change risky?]: Not very.

[Why is the change risky/not risky?]: It adds a background sanitization. I supposed it's possible this could cause problems, but we use existing history-removal APIs for this.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8981387 [details] [diff] [review]
container_5.patch

Patch to harden the privacy of the privacy.usercontext.about_newtab_segregation.enabled preference. Approved for 61.0b11.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

This needs a rebased patch for Beta uplift.

Comment 13

[Andrea Marchesini [:baku]]

Attachment: m-b

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/cab78187269b