1463357 - Split console's close [x] button should have tooltip showing Esc shortcut

Status: RESOLVED FIXED

(DevTools :: Console, enhancement, P3)

Description

[Jens]

The split console's button has no tooltip atm. But it should have because knowing that you can toggle it with [ESC] is very valuable. I'd suggest you add something like:

"Close console split (Esc)" as title so it will show as tooltip. 

Also important for accessibility.

(BTW: the DevTools close button tooltip could also be changed from "Close Developer Tools" to "Close Developer Tools (F12)". Adding another bug this?)

Comment 1

[Mantaroh Yoshinaga[:mantaroh]]

Attachment: Bug 1463357 - Add tooltip to the console button of split console and sidebar.

This patch add tooltip to close buttons of webconsole.

Review commit: https://reviewboard.mozilla.org/r/256406/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/256406/

Comment 2

[Code Review Bot [:reviewbot]]

Comment on attachment 8991509 [details]
Bug 1463357 - Add tooltip to the console button of split console and sidebar.

https://reviewboard.mozilla.org/r/256406/#review263286


Code analysis found 1 defect in this patch:
 - 1 defect found by mozlint

You can run this analysis locally with:
 - `./mach lint path/to/file` (JS/Python)


If you see a problem in this automated review, please report it here: http://bit.ly/2y9N9Vx


::: devtools/client/locales/en-US/webconsole.properties:281
(Diff revision 1)
>  # current inspected page is navigated to a new location.
>  # Parameters: %S is the new URL.
>  webconsole.navigated=Navigated to %S
> +
> +# LOCALIZATION NOTE (webconsole.closeSplitConsoleButton.tooltip): This is the tooltip for
> +# the close button ofthe split console.

Warning: Ofthe  ==> of the [codespell]

Comment 3

[Mantaroh Yoshinaga[:mantaroh]]

Comment on attachment 8991509 [details]
Bug 1463357 - Add tooltip to the console button of split console and sidebar.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/256406/diff/1-2/

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8991509 [details]
Bug 1463357 - Add tooltip to the console button of split console and sidebar.

https://reviewboard.mozilla.org/r/256406/#review263318

Thanks for the patch Mantaroh, and additional thanks for the tooltip on the sidebar close button !
I tested the patch and everything looks fine. Let's land this :)

Comment 5

[Mantaroh Yoshinaga[:mantaroh]]

Comment on attachment 8991509 [details]
Bug 1463357 - Add tooltip to the console button of split console and sidebar.

https://reviewboard.mozilla.org/r/256406/#review263318

Thanks!

The try build looks green:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=76535752d2a05ffa592ef19238685ba9cc11bc11

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/49707eda3179
Add tooltip to the console button of split console and sidebar. r=nchevobbe

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/49707eda3179