Closed Bug 1464162 Opened 6 years ago Closed 6 years ago

Make a few vector operations more efficient by reserving size beforehand.

Categories

(Core :: WebRTC: Signaling, enhancement, P3)

Product:
Core
Component:
WebRTC: Signaling
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla62
Tracking Flags:
Tracking Status
firefox62 --- fixed

People

(Reporter: janx, Assigned: janx)

Details

Attachments

(1 file)

Bug 1464162 - Make a few vector operations more efficient by reserving size beforehand. r?jya
46 bytes, text/x-phabricator-request
jya
: review+
Details | Review 
These automated fixes were generated like so:

    ./mach configure --enable-clang-plugin
    ./mach build-backend --backend=CompileDB
    run-clang-tidy-6.0.py -p obj-x86_64-pc-linux-gnu/ -fix -checks=-*,performance-inefficient-vector-operation *
These automated fixes were generated like so:
    ./mach configure --enable-clang-plugin
    ./mach build-backend --backend=CompileDB
    run-clang-tidy-6.0.py -p obj-x86_64-pc-linux-gnu/ -fix -checks=-*,performance-inefficient-vector-operation *
Attachment #8980379 - Flags: review?(jyavenard)
Comment on attachment 8980379 [details]
Bug 1464162 - Make a few vector operations more efficient by reserving size beforehand. r?jya

I'm not the right person to review this.
:drno can better direct you
Flags: needinfo?(drno)
Attachment #8980379 - Flags: review?(jyavenard)
on 2nd thought, they do make sense, so I'll accept it.
Flags: needinfo?(drno)
Comment on attachment 8980379 [details]
Bug 1464162 - Make a few vector operations more efficient by reserving size beforehand. r?jya

Jean-Yves Avenard [:jya] has approved the revision.

https://phabricator.services.mozilla.com/D1381
Attachment #8980379 - Flags: review+
Cool, thanks!
Keywords: checkin-needed
you haven't addressed my comment (or I don't know how to use phabricator properly)
Keywords: checkin-needed
Component: Audio/Video → WebRTC: Signaling
(In reply to Jean-Yves Avenard [:jya] from comment #6)
> you haven't addressed my comment (or I don't know how to use phabricator
> properly)

Oops, indeed! Thanks for being watchful. I assumed your comments would be copied to Bugzilla as with MozReview. I'll address them shortly.
Nits addressed, except the one about the pre-existing ugly const_cast. Please let me know if you'd like me to change it in some way, otherwise let's merge this patch.
Flags: needinfo?(jyavenard)
Rank: 25
Priority: -- → P3
All green! Go for launch.
Keywords: checkin-needed
Pushed by apavel@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a0c658fae24c
Make a few vector operations more efficient by reserving size beforehand. r=jya
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/a0c658fae24c
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox62: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
Flags: needinfo?(jyavenard)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: