1464904 - font-family: -apple-system; with weight bold not working

Status: VERIFIED FIXED

(Core :: Layout: Text and Fonts, defect, P1)

Description

[Ray Z.]

Attachment: Screen Shot 2018-05-28 at 5.04.10 PM.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:61.0) Gecko/20100101 Firefox/61.0
Build ID: 20180524181234

Steps to reproduce:

Use system font CSS stack, e.g.:
font-family: -apple-system, system-ui, BlinkMacSystemFont, "Segoe UI", Roboto, "Helvetica Neue", Arial, sans-serif;

And set some text bold:
font-weight: bold;

Live demo:
https://codepen.io/anon/pen/pKzxrQ

Platform:
Firefox 61.8b8; macOS 10.13.4

Side note:
Firefox 60 has no problem with it



Actual results:

No bold font weight for "-apple-system"


Expected results:

Render bold font weight for "-apple-system"

Comment 1

[Timothy Nikkel (:tnikkel)]

I only see this in beta, not nightly. It affects many sites (ie facebook). Regression range on the beta channel for me is

https://hg.mozilla.org/releases/mozilla-beta/pushloghtml?fromchange=8284f435a1cb5681c3dd2d08591aa5df2d8d5846&tochange=f8c381b7d9a42ecbe4ed34792cd98430b32b6dd0

The only thing that looks relevant is unsetting the EARLY_BETA_OR_EARLIER flag. So maybe we have some font stuff that depends on that?

Comment 2

[Jonathan Kew [:jfkthame]]

Oh dear.... that'll be related to disabling variable-font support for later beta. :(

Presumably if you manually reset layout.css.font-variations.enabled to true, the problem goes away? (That may require a browser restart, I think.)

Comment 3

[Timothy Nikkel (:tnikkel)]

(In reply to Jonathan Kew (:jfkthame) from comment #2)
> Presumably if you manually reset layout.css.font-variations.enabled to true,
> the problem goes away? (That may require a browser restart, I think.)

Yes, that fixes the problem.

Comment 4

[Ray Z.]

(In reply to Jonathan Kew (:jfkthame) from comment #2)
> Oh dear.... that'll be related to disabling variable-font support for later
> beta. :(
> 
> Presumably if you manually reset layout.css.font-variations.enabled to true,
> the problem goes away? (That may require a browser restart, I think.)

Yes, that fixed it after a restart. Is that just a workaround or proper fix?

Comment 5

[Jonathan Kew [:jfkthame]]

That's a workaround; we need to fix this properly before Firefox 61 ships.

Confirmed that the same problem occurs in Nightly (Fx62) if the font-variations pref is explicitly set to false. (On Fx62 the plan is to ship with the feature enabled, so users won't generally see the issue. But for Fx61 it'll ship disabled, so it's critical we fix this now for Beta.)

Comment 6

[Jonathan Kew [:jfkthame]]

Attachment: When font-variations support is preffed off, do not set up variation ranges in the gfxFontEntry for a system font, so that font selection will rely only on the static properties of the faces

This restores use of the proper bold face of -apple-system when variations are preffed off.

Comment 7

[Jonathan Kew [:jfkthame]]

[Tracking Requested - why for this release]:
This negatively affects rendering of major sites (e.g. Facebook) on macOS.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/315a0483bab2
When font-variations support is preffed off, do not set up variation ranges in the gfxFontEntry for a system font, so that font selection will rely only on the static properties of the faces. r=lsalzman

Comment 9

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/315a0483bab2

Comment 10

[Jonathan Kew [:jfkthame]]

Comment on attachment 8981367 [details] [diff] [review]
When font-variations support is preffed off, do not set up variation ranges in the gfxFontEntry for a system font, so that font selection will rely only on the static properties of the faces

Approval Request Comment
[Feature/Bug causing the regression]: Variable Fonts (primarily a result of the changes in bug 1454598)
[User impact if declined]: bold styling not working for macOS 10.13 users on pages that use the -apple-system font family (e.g. Facebook) when Variable Fonts is preffed off (which will be the default in Fx61)
[Is this code covered by automated tests?]: no, we don't have CI running macOS 10.13
[Has the fix been verified in Nightly?]: not yet, tested in local build
[Needs manual test from QE? If yes, steps to reproduce]: yes - on macOS 10.13, visit Facebook and check that bold works; visit about:config and check that non-default prefs are shown in bold
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: trivial patch to disable a block of variations-related code when the feature is preffed off
[String changes made/needed]: none

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8981367 [details] [diff] [review]
When font-variations support is preffed off, do not set up variation ranges in the gfxFontEntry for a system font, so that font selection will rely only on the static properties of the faces

Fixes a critical font rendering regression for OSX systems when variation fonts are disabled. Approved for 61.0b10.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/8735fe57245e

Comment 13

[Cristian Fogel [:cfogel]]

Fix confirmed on 61.0b10, and on 62.0a1.
Verified with MacOS 10.13.4.