146509 - Tab completion doesn't work with non-alphanumeric characters

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, defect)

Description

[James Ross]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.0rc2)
Gecko/20020510
BuildID:    2002051006

The tab completion in ChatZilla seems to fail if a nick (for example) has any
non-alphanumeric characters in it. For example, it's quite common to use a pipe
(|) to seperate one's status in a nickname. Once you have a | in the nickname
you're typing, tab-completion simply fails to do anything.

Reproducible: Always
Steps to Reproduce:
1. Open ChatZilla.
2. Join a channel on a server that has nicknames with a pipe (|).
3. Type someone's nickname up to and including the pipe.
4. Hit tab.

Actual Results:  Nothing happens - tab completion doesn't do anything.

Expected Results:  Nickname is tab completed, as normal.

I've tracked this down to line 824 of content/chatzilla/handlers.js:

    var wordStart = line.substr(0, selStart).search(/\s\w*$/);

The problem, as far as I can tell, is that \w will only match stuff in the set
[0-9a-zA-Z_], meaning once you have typed any other character of a nickname,
etc., tab completion simply fails.

I would suggest that changing the \w to \S would fix this, given that \S
represents [^\s] - which is really what we want here (this assumes \S exists in
JS regexps, otherwise just use [^\s]).

Comment 1

[Samuel Sieb]

*** Bug 146487 has been marked as a duplicate of this bug. ***

Comment 2

[Samuel Sieb]

Attachment: change the regex to use \S

Comment 3

[Robert Ginda]

Comment on attachment 91463 [details] [diff] [review]
change the regex to use \S

r=rginda

Comment 4

[Asa Dotzler [:asa]]

Comment on attachment 91463 [details] [diff] [review]
change the regex to use \S

a=asa (on behalf of drivers) for checkin to the 1.1 trunk.

Comment 5

[Samuel Sieb]

checked in