Closed
Bug 146522
Opened 22 years ago
Closed 22 years ago
Publishing command should be more accessible
Categories
(SeaMonkey :: Composer, defect)
SeaMonkey
Composer
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla1.0.1
People
(Reporter: cmanske, Assigned: cmanske)
Details
(Keywords: polish, Whiteboard: publish[adt2 RTM][fixed in trunk and branch]custrtm-)
Attachments
(1 file, 1 obsolete file)
13.56 KB,
patch
|
akkzilla
:
review+
dveditz
:
superreview+
chofmann
:
approval+
|
Details | Diff | Splinter Review |
Recent usability testing has revealed that the Publish command needs to be more visible, especially when editing a new page or a local file. Currently, the Publish button is only visible on the toolbar when editing a remote file. Also, 5 out of 6 users tested had trouble finding the "Publish" menuitem in the File menu, even though they had the File menu open!
Assignee | ||
Comment 1•22 years ago
|
||
In general, this simplifies the Save and Publish commands. With this patch they have separate keybindings and toolbar buttons. In ComposerCommands.js at @@ -335,39 +335,32 @@: In the nsSaveCommand, fix enabling of command when editing remote file and don't do publishing when Save command is executed when editing a remote file. at @@ -1352,22 +1369,19 @@: In the SaveDocument() method, don't do publishing when Save is used while editing a remote file -- force the SaveAs dialog instead. at @@ -1667,71 +1698,21 @@: Eliminate the switching of Publish and Save buttons on toolbar and switching of "Ctrl/Cmd+S" keybinding between Publish and Save commands. editor.xul: at @@ -141,16 +141,17 @@: Move the "Export to Text" menuitem to the "Tools" menu (this is according to the latest menu specs). at @@ -171,20 +172,20 @@: Move the "H.Line" button to the end of the toolbar and hide both "Anchor" and "H.Line" toolbar buttons to make room for the "Publish" button. 5 out of 6 users tested did not understand what the Anchor button did, so given our target audience, these two items are not important enough to merit taking up valuable space on the toolbar. Note that if we decide to remove just one, I favor keeping the H.Line button. editorOverlay.xul: at @@ -34,17 +34,18 @@: Fix keybindings so "Ctrl/Cmd+S" is always for Save and "Ctrl/Cmd+Shift+S" is always for "Publish" at @@ -133,17 +134,17 @@: Added accesskeykey for "Export to Text" command so we wouldn't have to move it "&fileexporttotext.accesskey;" between DTD files. at @@ -309,20 +310,20 @@: Reorganize the Save and Publish menuitems to improve visibility. Current grouping is: ------------------------ Save Save As... Save As Charset... Publish Publish As... --------------------- Export to Text... Revert to last saved ---------------------- This patch changes this to: ------------------------- Save Save As... Save As Charset... ------------------------- Publish Publish As... ------------------------- Revert to Last Saved ------------------------- at @@ -381,22 +382,22 @@: The order of items in the "Insert Menu" was changed to put more important items at the top and reflect the order of items in the toolbar. at @@ -668,17 +669,17 @@: Remove "hidden" from Publish button -- it is always visible.
Assignee | ||
Updated•22 years ago
|
Comment 2•22 years ago
|
||
I'd rather see the File menu organized like this: ... ------------------------- Save Save As... Save As Charset... Revert to Last Saved ------------------------- Publish Publish As... ------------------------- ... I don't like groupings of 1 if it'd be ok to add it to an existing group. The above should help Publish stand out a bit more (than if it has a one-item group below it).
OS: Windows 2000 → All
Comment 3•22 years ago
|
||
Comment on attachment 84834 [details] [diff] [review] patch v1 is there some reason the accesskey is added to the command instead of the menu item?
Assignee | ||
Comment 4•22 years ago
|
||
Re: comment #2: Yes, I agree that a item by itself in a group isn't good, but this "Revert" item actually refers to both "Saved" and "Published" files, so you can't put it with either of those groups. In fact, I meant to suggest that maybe we should change the menu text to just "Revert" since current wording implies it applies only to save? We could also simply keep "Export to Text" with "Revert..." as it is now. Re: comment #3: As I tried to explain in patch comments, if I moved the accesskey to the menuitem, which moved from editorOverlay.xul to editor.xul, I'd have to move the DTD string as well. I was trying to minimize code changes and it's better to keep the label and accesskey definitions next to each other in the DTD file.
Updated•22 years ago
|
Whiteboard: publish[adt1 RTM][FIX IN HAND][need r=,sr=] → publish[adt1 RTM][FIX IN HAND][need r=,sr=] custrtm
Comment 5•22 years ago
|
||
Lowering impact to [ADT2 RTM], per ADT triage.
Whiteboard: publish[adt1 RTM][FIX IN HAND][need r=,sr=] custrtm → publish[adt2 RTM][FIX IN HAND][need r=,sr=] custrtm
Assignee | ||
Comment 6•22 years ago
|
||
After further review of usability tests and discussion with Composer and UE staff, this patch reflects final decision for the File menu: --------------------- Save Save As... Save As Charset... --------------------- Publish Publish As... --------------------- Revert --------------------- Export to Text... Browse Page Send Page ... (rest as before) Differences from previous patch: "Revert" menuitem text simplified since it applies after both saving or publishing files. Access key changed to "v". We decided that moving "Export to Text" to the tools menu would hide the item too much, so it remains in the File menu but moved to the group with "Browse page" etc.
Attachment #84834 -
Attachment is obsolete: true
Comment 7•22 years ago
|
||
Comment on attachment 85807 [details] [diff] [review] patch v2 r=akkana I had some problems testing it, like the publish button greying out then not coming back even if publishing failed, but that happened without the patch too; Charley thinks that's fixed by the patch in bug 134883.
Attachment #85807 -
Flags: review+
Assignee | ||
Updated•22 years ago
|
Whiteboard: publish[adt2 RTM][FIX IN HAND][need r=,sr=] custrtm → publish[adt2 RTM][FIX IN HAND][need sr=] custrtm
Updated•22 years ago
|
Whiteboard: publish[adt2 RTM][FIX IN HAND][need sr=] custrtm → publish[adt2 RTM][FIX IN HAND][need sr=] custrtm-
Comment 8•22 years ago
|
||
Comment on attachment 85807 [details] [diff] [review] patch v2 sr=dveditz Since there's a UI text change please inform the l10n team and get whatever approvals required.
Attachment #85807 -
Flags: superreview+
Assignee | ||
Comment 9•22 years ago
|
||
checked into trunk
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Keywords: adt1.0.1
Resolution: --- → FIXED
Whiteboard: publish[adt2 RTM][FIX IN HAND][need sr=] custrtm- → publish[adt2 RTM][fixed in trunk]custrtm-
Target Milestone: mozilla1.0 → mozilla1.0.1
Comment 10•22 years ago
|
||
adding adt1.0.1+ for everything but the string change. Please get drivers approval and check into the branch.
Assignee | ||
Updated•22 years ago
|
Keywords: mozilla1.0.1
Comment 12•22 years ago
|
||
l10n approved IF you check this into the branch by tomorrow. thanks
Comment 13•22 years ago
|
||
Comment on attachment 85807 [details] [diff] [review] patch v2 a=chofmann for 1.0.1 add the fixed1.0.1 keyword after checking in to the branch
Attachment #85807 -
Flags: approval+
Updated•22 years ago
|
Keywords: mozilla1.0.1 → mozilla1.0.1+
Comment on attachment 85807 [details] [diff] [review] patch v2 a=shaver for the 1.1a branch. (Pretend I added a checkmark.)
Assignee | ||
Comment 15•22 years ago
|
||
checked into mozilla1.0.1 branch
Keywords: mozilla1.0.1+ → fixed1.0.1
Whiteboard: publish[adt2 RTM][fixed in trunk]custrtm- → publish[adt2 RTM][fixed in trunk and branch]custrtm-
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•