1465274 - webrtc compile failure on ppc64(le): g++: error: unrecognized command line option ‘-msse2'

Status: RESOLVED FIXED

(Firefox Build System :: General: Unsupported Platforms, defect, P5)

Description

[Cameron Kaiser [:spectre]]

Spun off from bug 1434589 per request, though the fix here will necessarily fix that bug as well, at least on Linux.

Comment 1

[Cameron Kaiser [:spectre]]

Attachment: Add ppc64 to webrtc, regenerate moz.build to remove SSE2 dependency for Linux

Same patch as in that bug.

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 8981683 [details] [diff] [review]
Add ppc64 to webrtc, regenerate moz.build to remove SSE2 dependency for Linux

Review of attachment 8981683 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/854d7b3f850d
Add ppc64 to webrtc, regenerate moz.build to remove SSE2 dependency for Linux. r=froydnj

Comment 4

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/854d7b3f850d

Comment 5

[Jan Beich]

Comment on attachment 8981683 [details] [diff] [review]
Add ppc64 to webrtc, regenerate moz.build to remove SSE2 dependency for Linux

[Approval Request Comment]
If this is not a sec:{high,crit} bug, please state case for ESR consideration:  bug 1393119 regression
User impact if declined: Broken build on Linux non-x86/x86_64 unless --disable-webrtc. Here's a list of affected architectures:
https://searchfox.org/mozilla-central/rev/38bcf897f1fa/media/webrtc/trunk/build/build_config.h#110-173
Fix Landed on Version: Firefox 62
Risk to taking this patch (and alternatives if risky): No, can only break build on Linux at worst.
String or UUID changes made by this patch: None

Comment 6

[Jan Beich]

Comment on attachment 8981683 [details] [diff] [review]
Add ppc64 to webrtc, regenerate moz.build to remove SSE2 dependency for Linux

See comment 5. Probably less critical for non-ESR because rolling distributions rarely support non-x86/x86_64.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8981683 [details] [diff] [review]
Add ppc64 to webrtc, regenerate moz.build to remove SSE2 dependency for Linux

Needed for bug 1464680. Approved for 61.0b11 and ESR 60.1.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/5b046ff33709

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr60/rev/af160715ee91