Closed
Bug 1465378
Opened 6 years ago
Closed 6 years ago
remove reference to old winxp in manifest file
Categories
(Core :: DOM: Security, enhancement, P3)
Tracking
()
RESOLVED
FIXED
mozilla62
Tracking | Status | |
---|---|---|
firefox62 | --- | fixed |
People
(Reporter: jmaher, Assigned: apavel)
References
Details
(Whiteboard: [domsecurity-backlog3])
Attachments
(3 files, 1 obsolete file)
925 bytes,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
1.02 KB,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
1.13 KB,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
we have 2 references in this manifest: https://searchfox.org/mozilla-central/source/testing/web-platform/meta/content-security-policy/generic/generic-0_10.html.ini#5 when removing, if there are no remaining conditions, remove the test name
Reporter | ||
Comment 1•6 years ago
|
||
there are 2 additional manifests: https://searchfox.org/mozilla-central/source/testing/web-platform/meta/content-security-policy/media-src/media-src-7_1.html.ini#5 https://searchfox.org/mozilla-central/source/testing/web-platform/meta/content-security-policy/media-src/media-src-redir-bug.sub.html.ini#3
Updated•6 years ago
|
Priority: -- → P3
Whiteboard: [domsecurity-backlog3]
Assignee | ||
Comment 2•6 years ago
|
||
Assignee: nobody → apavel
Attachment #8982169 -
Flags: review?(jmaher)
Reporter | ||
Comment 3•6 years ago
|
||
Comment on attachment 8982169 [details] [diff] [review] remove reference to old winxp in generic-0_10.html.ini Review of attachment 8982169 [details] [diff] [review]: ----------------------------------------------------------------- ::: testing/web-platform/meta/content-security-policy/generic/generic-0_10.html.ini @@ +6,3 @@ > [Violation report status OK.] > expected: > + if not debug and (os == "win") : TIMEOUT this now applies to win7/win10 whereas before this applied to winxp only. We need to remove the entire clause (and delete 'expected' and [<name>] with no conditions)
Attachment #8982169 -
Flags: review?(jmaher) → review-
Assignee | ||
Comment 4•6 years ago
|
||
Attachment #8982169 -
Attachment is obsolete: true
Attachment #8982176 -
Flags: review?(jmaher)
Reporter | ||
Comment 5•6 years ago
|
||
Comment on attachment 8982176 [details] [diff] [review] remove reference to old winxp in generic-0_10.html.ini Review of attachment 8982176 [details] [diff] [review]: ----------------------------------------------------------------- perfect. As you can see the test is already disabled for all of win/!debug- now it is easier to read
Attachment #8982176 -
Flags: review?(jmaher) → review+
Reporter | ||
Updated•6 years ago
|
Keywords: checkin-needed
Reporter | ||
Comment 6•6 years ago
|
||
:apavel, there are 2 other files (comment 1) that need attention as well- they were the same bugzilla component so I put them in the same bug. lets do checkin-needed after all patches are ready
Flags: needinfo?(apavel)
Keywords: checkin-needed
Assignee | ||
Comment 7•6 years ago
|
||
Flags: needinfo?(apavel)
Attachment #8982191 -
Flags: review?(jmaher)
Assignee | ||
Comment 8•6 years ago
|
||
Attachment #8982192 -
Flags: review?(jmaher)
Reporter | ||
Comment 9•6 years ago
|
||
Comment on attachment 8982191 [details] [diff] [review] removed media-src-redir-bug.sub.html.ini manifest file Review of attachment 8982191 [details] [diff] [review]: ----------------------------------------------------------------- I like removed files
Attachment #8982191 -
Flags: review?(jmaher) → review+
Reporter | ||
Comment 10•6 years ago
|
||
Comment on attachment 8982192 [details] [diff] [review] removed win XP references in media-src-7_1.html.ini Review of attachment 8982192 [details] [diff] [review]: ----------------------------------------------------------------- well done
Attachment #8982192 -
Flags: review?(jmaher) → review+
Reporter | ||
Updated•6 years ago
|
Keywords: checkin-needed
Comment 11•6 years ago
|
||
Pushed by apavel@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/af54112146f9 remove reference to old winxp in manifest file r=jmaher https://hg.mozilla.org/integration/mozilla-inbound/rev/cd597e745065 removed manifest file r=jmaher https://hg.mozilla.org/integration/mozilla-inbound/rev/f443ef59e6da remove reference to old winxp in manifest file r=jmaher
Keywords: checkin-needed
Comment 12•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/af54112146f9 https://hg.mozilla.org/mozilla-central/rev/cd597e745065 https://hg.mozilla.org/mozilla-central/rev/f443ef59e6da
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in
before you can comment on or make changes to this bug.
Description
•