Closed
Bug 1465810
Opened 6 years ago
Closed 6 years ago
Update Codemirror to 5.38.0
Categories
(DevTools :: Source Editor, defect)
DevTools
Source Editor
Tracking
(firefox62 fixed)
RESOLVED
FIXED
Firefox 62
Tracking | Status | |
---|---|---|
firefox62 | --- | fixed |
People
(Reporter: tjr, Assigned: gl)
References
(Blocks 1 open bug)
Details
(Whiteboard: [third-party-lib-audit])
Attachments
(1 file)
This is a (semi-)automated bug making you aware that there is an available upgrade for an embedded third-party library. You can leave this bug open, and it will be updated if a newer version of the library becomes available. If you close it as WONTFIX, please indicate if you do not wish to receive any future bugs upon new releases of the library. Codemirror is currently at version 5.37.0 in mozilla-central, and the latest version of the library released is 5.38.0. I fetched the latest version of the library from https://github.com/codemirror/CodeMirror/.
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → gl
Status: NEW → ASSIGNED
Comment hidden (mozreview-request) |
Comment 2•6 years ago
|
||
mozreview-review |
Comment on attachment 8982545 [details] Bug 1465810 - Update Codemirror to 5.38.0. https://reviewboard.mozilla.org/r/248526/#review254748 It looks like the bundle got minified down to one line - was that intentional?
Assignee | ||
Comment 3•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=20e261f03cf44bc5707083442547f07ffe22af51
Assignee | ||
Comment 4•6 years ago
|
||
(In reply to Brian Grinstead [:bgrins] from comment #2) > Comment on attachment 8982545 [details] > Bug 1465810 - Update Codemirror to 5.38.0. > > https://reviewboard.mozilla.org/r/248526/#review254748 > > It looks like the bundle got minified down to one line - was that > intentional? It was actually minified the last time we upgraded and then it got reverted in Bug 1465080
Comment 5•6 years ago
|
||
mozreview-review |
Comment on attachment 8982545 [details] Bug 1465810 - Update Codemirror to 5.38.0. https://reviewboard.mozilla.org/r/248526/#review254764 > It was actually minified the last time we upgraded and then it got reverted > in Bug 1465080 Yeah I thought this seemed familiar. What can we do to make sure we don't keep bouncing back and forth between the minified and non-minfiied version?
Attachment #8982545 -
Flags: review?(bgrinstead) → review+
Pushed by gabriel.luong@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/b23905eefff4 Update Codemirror to 5.38.0. r=bgrins
Comment 7•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/b23905eefff4
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 62
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•