1466385 - Allow move semantics with Promise

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Jean-Yves Avenard [:jya]]

Bug 1466221 allowed non wrappercached, non-refcounted object to be used with DOM.

This requires move semantics in Promise (so that the JS binding takes ownership of the C++ object).

Comment 1

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1466385. Use forwarding reference in MaybeResolve.

This allows move semantics when resolving Promises

Review commit: https://reviewboard.mozilla.org/r/248716/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/248716/

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8982862 [details]
Bug 1466385. Use forwarding reference in MaybeResolve.

https://reviewboard.mozilla.org/r/248716/#review254914

Comment 3

[Jean-Yves Avenard [:jya]]

Bug 1466168 has removed Forward :(

Comment 4

[Jean-Yves Avenard [:jya]]

Comment on attachment 8982862 [details]
Bug 1466385. Use forwarding reference in MaybeResolve.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/248716/diff/1-2/

Comment 5

[Boris Zbarsky [:bzbarsky]]

Sorry.  :(  It was not clear that we were about to do that...

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a014f0010edb
Use forwarding reference in MaybeResolve. r=bz

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/a014f0010edb