1466631 - Mercadolibre engines have the wrong encoding (and one wrong icon)

Status: RESOLVED FIXED

(Firefox :: Search, defect, P1)

Description

[Mike Kaply [:mkaply]]

Searching with international characters isn't working on Mercadolivre engines. Switching to UTF-8 fixes for all except for the .br version.

Also .br has the wrong icon.

Comment 1

[Mike Kaply [:mkaply]]

Attachment: Bug 1466631 - Move MercadoLibre to UTF-8, https and fix icon.

Review commit: https://reviewboard.mozilla.org/r/248980/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/248980/

Comment 2

[Mike Kaply [:mkaply]]

Comment on attachment 8983142 [details]
Bug 1466631 - Move MercadoLibre to UTF-8, https and fix icon.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/248980/diff/1-2/

Comment 3

[Mike Kaply [:mkaply]]

We don't have a deal with them anymore, so I'm going to fix the br engine to match the others and remove our codes.

Comment 4

[Francesco Lodolo [:flod]]

Comment on attachment 8983142 [details]
Bug 1466631 - Move MercadoLibre to UTF-8, https and fix icon.

https://reviewboard.mozilla.org/r/248980/#review255384

Not sure if you want to change pt-BR in this bug or in a follow up, but the changes look good.

Comment 5

[Mike Kaply [:mkaply]]

Once my list.json move lands, I'll fix all of these.

Comment 6

[Francesco Lodolo [:flod]]

(In reply to Mike Kaply [:mkaply] from comment #5)
> Once my list.json move lands

Which bug is that? I don't think I've seen anything related to moving list.json, and I definitely need to update a bunch of tools.

Comment 7

[Francesco Lodolo [:flod]]

Ah, that's bug 1437942. Didn't realize it was moving stuff around like that, I need to update scripts and documentation.

Comment 8

[Mike Kaply [:mkaply]]

Comment on attachment 8983142 [details]
Bug 1466631 - Move MercadoLibre to UTF-8, https and fix icon.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/248980/diff/2-3/

Comment 9

[Mike Kaply [:mkaply]]

I know you already r+ the earlier patch, but thought you might want to look at the final patch.

Moved to UTF-8, fixed icon, removed our codes and fixed the mercadolivre engine to use the regular URLS.

Comment 10

[Francesco Lodolo [:flod]]

(In reply to Mike Kaply [:mkaply] from comment #9)
> I know you already r+ the earlier patch, but thought you might want to look
> at the final patch.
> 
> Moved to UTF-8, fixed icon, removed our codes and fixed the mercadolivre
> engine to use the regular URLS.

Double checked and everything looks right.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f8598c3a26bb
Move MercadoLibre to UTF-8, https and fix icon. r=flod

Comment 12

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/f8598c3a26bb

Comment 13

[Liz Henry (:lizzard) (relman/hg->git project)]

Mike, do you want to request uplift to 62?

Comment 14

[Mike Kaply [:mkaply]]

Comment on attachment 8983142 [details]
Bug 1466631 - Move MercadoLibre to UTF-8, https and fix icon.

Sure. No harm in it.

Approval Request Comment
[Feature/Bug causing the regression]: Cleanup search engine
[User impact if declined]: Search engines not working properly
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: Low risk
[Why is the change risky/not risky?]: Simple icon replacement, cleanup.
[String changes made/needed]:

Comment 15

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8983142 [details]
Bug 1466631 - Move MercadoLibre to UTF-8, https and fix icon.

Changes limited to fixing MercadoLibre, let's go ahead and uplift for beta 8.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/1a3e6da8c4df