Closed
Bug 1468349
Opened 6 years ago
Closed 6 years ago
Web Authentication - Support FreeBSD
Categories
(Core :: DOM: Device Interfaces, enhancement, P1)
Tracking
()
RESOLVED
FIXED
mozilla62
People
(Reporter: jcj, Assigned: jcj)
References
()
Details
(Keywords: feature, Whiteboard: [webauthn][webauthn-hw])
Attachments
(3 files)
This is to uplift FreeBSD support from u2f-hid-rs.
Comment 1•6 years ago
|
||
Upstream PR: https://github.com/jcjones/u2f-hid-rs/pull/62 * Extract hidproto module from linux::hidraw Make the protocol parts independent of Linux code, in preparation for adding FreeBSD support. * Add FreeBSD (uhid + devd) support Tested with a YubiKey 4.
Pushed by jjones@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/80190d88549c Web Authentication - Add FreeBSD Support
Assignee | ||
Comment 3•6 years ago
|
||
Note: While Lando stripped the r=jcj off, this was reviewed by me and ttaubert upstream.
Comment 4•6 years ago
|
||
Backed out for failing build bustages Push that caused the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=80190d88549cf49b79fea1d350e65d8828f33810 Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=182933085&repo=autoland&lineNumber=9360 Backout: https://hg.mozilla.org/integration/autoland/rev/a6c7994970b7b0a79dc7a0668bfff9f4597bb640
Assignee | ||
Comment 5•6 years ago
|
||
Apologies for the false-start on uplifting u2f-hid-rs (w/o ttaubert's guidance, who has been handling this before). That said, there's a problem with `nom`, a dependency of `devd-rs` used for FreeBSD: $ mach vendor rust 0:23.31 The following files exceed the filesize limit of 102400: third_party/rust/nom-1.2.4/src/macros.rs Please find a way to reduce the sizes of these files or talk to a build peer about the particular large files you are adding. The changes from `mach vendor rust` will NOT be added to version control. So I need to reach out to the build team and find out if we can let the 120768-byte nom-for-macos file in. It will be unused currently, as the only user of nom will be freebsd.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 8•6 years ago
|
||
mozreview-review |
Comment on attachment 8985037 [details] Bug 1468349 - Web Authentication - Add FreeBSD Support https://reviewboard.mozilla.org/r/250764/#review256988 Reviewed upstream.
Attachment #8985037 -
Flags: review?(jjones) → review+
Assignee | ||
Comment 9•6 years ago
|
||
mozreview-review |
Comment on attachment 8985038 [details] Bug 1468349 - Vendor in new freebsd deps for u2f-hid-rs https://reviewboard.mozilla.org/r/250766/#review257062 Note: compare to https://hg.mozilla.org/try/rev/aefcd2a3625860e2228aa8b12068eae1d12fdf13
Comment 10•6 years ago
|
||
mozreview-review |
Comment on attachment 8985038 [details] Bug 1468349 - Vendor in new freebsd deps for u2f-hid-rs https://reviewboard.mozilla.org/r/250766/#review257226
Attachment #8985038 -
Flags: review?(mgoodwin) → review+
Comment 11•6 years ago
|
||
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. hg error in cmd: hg rebase -s 39f22b0351c2893b26cb7c04dcc879a093bfa78a -d 35b28db3b16e: rebasing 468136:39f22b0351c2 "Bug 1468349 - Web Authentication - Add FreeBSD Support r=jcj" merging dom/webauthn/u2f-hid-rs/Cargo.toml merging dom/webauthn/u2f-hid-rs/README.md merging dom/webauthn/u2f-hid-rs/src/lib.rs merging dom/webauthn/u2f-hid-rs/src/linux/hidraw.rs merging dom/webauthn/u2f-hid-rs/src/macos/iokit.rs merging dom/webauthn/u2f-hid-rs/src/macos/monitor.rs merging dom/webauthn/u2f-hid-rs/src/macos/transaction.rs merging dom/webauthn/u2f-hid-rs/src/statemachine.rs merging dom/webauthn/u2f-hid-rs/src/util.rs rebasing 468137:49d76d6600b9 "Bug 1468349 - Vendor in new freebsd deps for u2f-hid-rs r=mgoodwin" (tip) merging Cargo.lock warning: conflicts while merging Cargo.lock! (edit, then use 'hg resolve --mark') unresolved conflicts (see hg resolve, then hg rebase --continue)
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 14•6 years ago
|
||
Pushed by jjones@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8ebf45b0854a Web Authentication - Add FreeBSD Support r=jcj https://hg.mozilla.org/integration/autoland/rev/ee93e9e7bcfd Vendor in new freebsd deps for u2f-hid-rs r=mgoodwin
Comment 15•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/8ebf45b0854a https://hg.mozilla.org/mozilla-central/rev/ee93e9e7bcfd
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
Assignee | ||
Comment 16•6 years ago
|
||
FreeBSD support for WebAuthn might be worthy of a relnote?
relnote-firefox:
--- → ?
Added to Firefox 62 release notes.
You need to log in
before you can comment on or make changes to this bug.
Description
•