1468830 - onBeforeRedirect with "responseHeaders" throws exception on internal/upgrade redirects

Status: RESOLVED FIXED

(WebExtensions :: Untriaged, defect)

Description

[Shane Caraveo (:mixedpuppy)]

Bug 1462006 includes new API support for identifying redirect reasons.  I want to land and uplift just the actual fix now, that is what this bug is for.

Also re-requesting flags set on 1462006

Comment 1

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1468830 ignore exceptions when retreiving response headers,

Review commit: https://reviewboard.mozilla.org/r/251054/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/251054/

Comment 2

[Luca Greco [:rpl] [:luca] [:lgreco]]

Comment on attachment 8985470 [details]
Bug 1468830 ignore exceptions when retreiving response headers,

https://reviewboard.mozilla.org/r/251054/#review257310

Comment 3

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8985470 [details]
Bug 1468830 ignore exceptions when retreiving response headers,

Approval Request Comment
[Feature/Bug causing the regression]: internal or upgrade redirects cause a failure if a webextension listener requests response headers.  
[User impact if declined]: some extensions may break all extensions using onBeforeRedirect listeners
[Is this code covered by automated tests?]: bug 1462006 adds more extensive support for this including new tests.  This change itself is very simple. Existing tests would catch any general breakage.
[Has the fix been verified in Nightly?]: not yet
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: simple try/catch patch
[String changes made/needed]: none

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e05d3484f97a
ignore exceptions when retreiving response headers, r=rpl

Comment 5

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/e05d3484f97a

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for Beta/ESR60 approval when you get a chance.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8985470 [details]
Bug 1468830 ignore exceptions when retreiving response headers,

Fixes extension bustage when onBeforeRedirect listeners are used. Approved for 61.0rc1 and ESR 60.1.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/41e630d33775

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr60/rev/5b7e2a2b06e1