1471305 - Remove obsolete footerURL code

Status: VERIFIED FIXED

(WebExtensions :: Themes, enhancement, P3)

Description

[Tim Nguyen :ntim]

footerURL is not displayed anywhere in Firefox, let's remove that.

Comment 1

[Manish [:manishkk]]

Please tell more about this.
How can I work on this?

Comment 2

[Tim Nguyen :ntim]

Here's the code you'll need to remove:
https://dxr.mozilla.org/mozilla-central/search?q=footerURL&case=false&regexp=false&path=toolkit

Comment 3

[Manish [:manishkk]]

what about these kinds of lines?
https://dxr.mozilla.org/mozilla-central/source/toolkit/mozapps/extensions/LightweightThemeManager.jsm#26

What to do with 'footerURL' here and how can I test?

Comment 4

[Tim Nguyen :ntim]

In that specific case, you should remove `"footerURL", ` from the array.

> how can I test?

Just make sure switching themes in the customize mode still works (Menu > Customize > Themes).

Comment 5

[Shivam Singhal [ :championshuttler ]]

Hi, i would like to work on this issue,

Comment 6

[Tim Nguyen :ntim]

(In reply to Shivam Singhal [:championshuttler] from comment #5)
> Hi, i would like to work on this issue,

In case you haven't, please set up a development environment (see https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Introduction ). Once that's done, feel free to remove the code from comment 2, and attach a patch once you're done.

Please let me know if you need help.

Comment 7

[Shivam Singhal [ :championshuttler ]]

Attachment: Bug 1471305 - Remove obsolete footerURL code.

Removing footerURL code , few of the lines are left , i am not sure how to delete them and what to use instead of them there.

Comment 8

[Tim Nguyen :ntim]

Comment on attachment 9008838 [details]
Bug 1471305 - Remove obsolete footerURL code.

Tim Nguyen :ntim has approved the revision.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e60665194092
Remove obsolete footerURL code. r=ntim

Comment 10

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9bb04fb52dd7
Backed out changeset e60665194092 for eslint failure at extensions/internal/LightweightThemeImageOptimizer.jsm on a CLOSED TREE

Comment 11

[Shivam Singhal [ :championshuttler ]]

Hi ntim , can you tell me what happened, did the commit revert now?

Comment 12

[Tim Nguyen :ntim]

(In reply to Shivam Singhal [:championshuttler] from comment #11)
> Hi ntim , can you tell me what happened, did the commit revert now?

Yes, the commit was reverted. There was a ESLint failure: https://treeherder.mozilla.org/logviewer.html#?job_id=199355439&repo=autoland&lineNumber=66

Your patch made ORIGIN_BOTTOM_LEFT unused, so you'll need to remove that variable definition: https://searchfox.org/mozilla-central/rev/99cbc0aec3e1c0b65ff9052523fb5c181b248f57/toolkit/mozapps/extensions/internal/LightweightThemeImageOptimizer.jsm#18

Once you've done that, the patch should be good to go.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/abcfb507d1e9
Remove obsolete footerURL code. r=ntim

Comment 14

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/abcfb507d1e9

Comment 15

[Vlad Jiman]

Verified according to comment #4 using Nightly 64.0a1 (2018-09-16) running on Windows 10 x64, no issues were found with the themes on the new version.