Closed
Bug 1473796
Opened 6 years ago
Closed 5 years ago
Add helper classes to emit bytecode for function
Categories
(Core :: JavaScript Engine, enhancement, P3)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla67
Tracking | Status | |
---|---|---|
firefox67 | --- | fixed |
People
(Reporter: arai, Assigned: arai)
References
Details
Attachments
(4 files)
Just like others (bug 1456006, bug 1456404). Emitting function consists of two parts: 1. emitting function declaration/expression on the parent script 2. emitting parameters/body in the child script To reuse the classes in BinAST streaming compilation which uses different compiler than current BytecodeEmitter which does "ParseNode=>bytecode", those 2 parts should be separated into 2 classes.
Assignee | ||
Updated•6 years ago
|
Summary: Add classes helper to emit bytecode for function → Add helper classes to emit bytecode for function
Assignee | ||
Comment 1•6 years ago
|
||
bug 1475458 needs to be addressed, in order to design the interface.
Depends on: 1475458
Assignee | ||
Comment 2•5 years ago
|
||
Assignee | ||
Comment 3•5 years ago
|
||
Depends on D19619
Assignee | ||
Comment 4•5 years ago
|
||
Depends on D19620
Assignee | ||
Comment 5•5 years ago
|
||
Depends on D19621
Assignee | ||
Comment 6•5 years ago
|
||
bug 1530324 removes wrapper for async, and also modifies the async body.
Depends on: 1530324
Pushed by arai_a@mac.com: https://hg.mozilla.org/integration/autoland/rev/f53c8cedef75 Part 1: Add DefaultEmitter. r=jorendorff https://hg.mozilla.org/integration/autoland/rev/d20d700c80d5 Part 2: Do not use TokenPos in BytecodeEmitter::{setFunctionBodyEndPos,setScriptStartOffsetIfUnset}. r=jorendorff https://hg.mozilla.org/integration/autoland/rev/7e1e3f35d7cf Part 3: Move DestructuringFlavor into its own header. r=jorendorff https://hg.mozilla.org/integration/autoland/rev/2429f6898afa Part 4: Add FunctionEmitter, FunctionScriptEmitter, and FunctionParamsEmitter. r=jorendorff
Comment 8•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f53c8cedef75
https://hg.mozilla.org/mozilla-central/rev/d20d700c80d5
https://hg.mozilla.org/mozilla-central/rev/7e1e3f35d7cf
https://hg.mozilla.org/mozilla-central/rev/2429f6898afa
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox67:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in
before you can comment on or make changes to this bug.
Description
•