Closed
Bug 1474306
Opened 6 years ago
Closed 6 years ago
Fix typo in the extension optionsType handler
Categories
(Toolkit :: General, defect)
Toolkit
General
Tracking
()
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: igt0, Assigned: igt0)
Details
Attachments
(1 file)
|
1.20 KB,
patch
|
mossop
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:61.0) Gecko/20100101 Firefox/61.0
Build ID: 20180703120607
Steps to reproduce:
XPIInstall.jsm has a typo in the optionsType handler:
if (addon.optionsType &&
addon.optionsType != AddonManager.OPTIONS_INLINE_BROWSER &&
addon.optionsType != AddonManager.OPTIONS_TYPE_TAB) {
throw new Error("Install manifest specifies unknown optionsType: " + addon.optionsType);
}
AddonManager.OPTIONS_INLINE_BROWSER doesn't exist, it should be AddonManager.OPTIONS_TYPE_INLINE_BROWSER
|
Assignee | |
Comment 1•6 years ago
|
||
Attachment #8990713 -
Flags: review?(michael.l.comella)
Assignee: nobody → igt0
I don't think I can review toolkit changes.
Product: Firefox for Android → Toolkit
Attachment #8990713 -
Flags: review?(michael.l.comella) → review?(dtownsend)
|
||
Comment 3•6 years ago
|
||
Comment on attachment 8990713 [details] [diff] [review] 0001-Bug-1474306-Fix-typo-in-the-extension-optionsType-ha.patch Review of attachment 8990713 [details] [diff] [review]: ----------------------------------------------------------------- Thanks!
Attachment #8990713 -
Flags: review?(dtownsend) → review+
|
|
Assignee | |
Updated•6 years ago
|
Keywords: checkin-needed
Pushed by archaeopteryx@coole-files.de: https://hg.mozilla.org/integration/mozilla-inbound/rev/b60d9901c566 Fix typo in the extension optionsType handler. r=Mossop
Keywords: checkin-needed
|
||
Comment 5•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/b60d9901c566
Status: UNCONFIRMED → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•