1474756 - Enable PGO for Windows opt-msvc builds

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Ryan VanderMeulen [:RyanVM]]

Attachment: enable PGO for the opt-msvc builds

Per bug 1463190 comment 19, let's enable PGO by default for the opt builds since those are the ones we want to make sure don't break as we go back and forth between MSVC and clang-cl as the builds we ship.

Green on Try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=778e93468e6e50fc3df8fbb3ee0996f3a654cbc4

As I mentioned on IRC, I'm really not feeling the need to do much more with labeling here. These jobs are just transient while we transition anyway.

Comment 1

[(Away)]

Comment on attachment 8991156 [details] [diff] [review]
enable PGO for the opt-msvc builds

Transient or not, I don't think these jobs should lie about what they are. Someone debugging these builds could lose a day or more from misunderstanding their contents. Please do update the section heading, description, job-name, and platform.

Comment 2

[Dan Minor [:dminor]]

Sorry, I wasn't aware that you were working on this. My landing bug 1445683 will presumably break this on win32. I guess I should back that out until we've definitively switched to clang-cl?

Comment 3

[Ryan VanderMeulen [:RyanVM]]

David's taking this bug, redirecting the NI to him.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

That said, we're 99.9% likely to switch back to MSVC anyway at some point (the current clang-cl switch was meant to be temporary), so it sounds like we're heading for trouble one way or another. If anything, it only goes to underscore why I think this bug needs to be a priority :)

Comment 5

[(Away)]

dminor, please assume that you need to keep msvc pgo functional for a while.

ryanvm, you can land whatever you have, I'm giving up on untangling this mess.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/eaf0c94feb46
Run Windows opt-msvc jobs with PGO enabled. r=dmajor

Comment 7

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/eaf0c94feb46

Comment 8

[Ionuț Goldan [:igoldan]]

As expected, lots of perf improvements now showed up on Windows OPT builds:

== Change summary for alert #14338 (as of Fri, 13 Jul 2018 18:15:28 GMT) ==

Improvements:

 37%  tp5o responsiveness windows7-32-msvc opt e10s stylo     0.70 -> 0.44
 37%  a11yr windows7-32-msvc opt e10s stylo                   305.14 -> 193.01
 29%  tp6_youtube windows7-32-msvc opt e10s stylo             331.08 -> 234.00
 28%  stylebench windows7-32-msvc opt e10s stylo              29.38 -> 37.63
 27%  a11yr windows10-64-msvc opt e10s stylo                  243.66 -> 178.97
 26%  displaylist_mutate windows7-32-msvc opt e10s stylo      5,090.81 -> 3,783.77
 22%  tp6_amazon windows7-32-msvc opt e10s stylo              296.88 -> 232.62
 20%  speedometer windows7-32-msvc opt e10s stylo             58.38 -> 70.15
 18%  tp6_youtube windows10-64-msvc opt e10s stylo            282.08 -> 232.08
 17%  stylebench windows10-64-msvc opt e10s stylo             35.18 -> 41.28
 15%  speedometer windows10-64-msvc opt e10s stylo            60.30 -> 69.26
 15%  damp windows7-32-msvc opt e10s stylo                    307.02 -> 261.89
 15%  tp6_amazon windows10-64-msvc opt e10s stylo             261.92 -> 223.75
 15%  tps windows7-32-msvc opt e10s stylo                     15.43 -> 13.18
 14%  displaylist_mutate windows10-64-msvc opt e10s stylo     3,950.87 -> 3,389.81
 13%  tart windows7-32-msvc opt e10s stylo                    3.10 -> 2.68
 13%  tp6_google windows7-32-msvc opt e10s stylo              483.29 -> 422.46
 12%  about_preferences_basic windows7-32-msvc opt e10s stylo 168.71 -> 147.83
 12%  tsvgr_opacity windows7-32-msvc opt e10s stylo           143.36 -> 126.22
 12%  tsvgx windows7-32-msvc opt e10s stylo                   232.13 -> 204.82
 12%  tpaint windows7-32-msvc opt e10s stylo                  155.99 -> 137.91
 10%  sessionrestore_no_auto_restore windows7-32-msvc opt e10s stylo319.92 -> 286.58
 10%  sessionrestore windows7-32-msvc opt e10s stylo          276.04 -> 248.00
 10%  perf_reftest_singletons windows7-32-msvc opt e10s stylo 59.12 -> 53.17
 10%  tp5o_scroll windows7-32-msvc opt e10s stylo             0.82 -> 0.74
 10%  tps windows10-64-msvc opt e10s stylo                    15.46 -> 13.91
 10%  tp6_google windows10-64-msvc opt e10s stylo             467.50 -> 421.25
  9%  damp windows10-64-msvc opt e10s stylo                   281.76 -> 255.06
  9%  tp6_facebook windows7-32-msvc opt e10s stylo            175.83 -> 159.62
  9%  ts_paint_webext windows7-32-msvc opt e10s stylo         378.67 -> 344.00
  9%  about_preferences_basic windows10-64-msvc opt e10s stylo157.92 -> 143.60
  9%  tresize windows10-64-msvc opt e10s stylo                7.62 -> 6.93
  9%  tpaint windows10-64-msvc opt e10s stylo                 146.99 -> 133.85
  9%  tabpaint windows7-32-msvc opt e10s stylo                57.09 -> 52.05
  9%  ts_paint_heavy windows7-32-msvc opt e10s stylo          372.17 -> 340.17
  9%  tart windows10-64-msvc opt e10s stylo                   2.87 -> 2.62
  8%  ts_paint windows7-32-msvc opt e10s stylo                369.79 -> 338.92
  8%  sessionrestore windows10-64-msvc opt e10s stylo         251.71 -> 232.83
  7%  tp6_facebook windows10-64-msvc opt e10s stylo           167.33 -> 155.33
  7%  sessionrestore_no_auto_restore windows10-64-msvc opt e10s stylo288.92 -> 269.00
  7%  ts_paint_heavy windows10-64-msvc opt e10s stylo         347.12 -> 324.17
  7%  sessionrestore_many_windows windows7-32-msvc opt e10s stylo2,441.25 -> 2,280.67
  6%  ts_paint_webext windows10-64-msvc opt e10s stylo        350.00 -> 327.58
  6%  ts_paint windows10-64-msvc opt e10s stylo               345.00 -> 323.08
  6%  tresize windows7-32-msvc opt e10s stylo                 8.47 -> 7.94
  6%  cpstartup content-process-startup windows7-32-msvc opt e10s stylo164.17 -> 153.83
  6%  tabpaint windows10-64-msvc opt e10s stylo               55.12 -> 51.99
  5%  cpstartup content-process-startup windows10-64-msvc opt e10s stylo157.71 -> 149.58
  5%  tp5o_scroll windows10-64-msvc opt e10s stylo            0.78 -> 0.74
  4%  sessionrestore_many_windows windows10-64-msvc opt e10s stylo2,354.17 -> 2,249.00
  4%  rasterflood_svg windows7-32-msvc opt e10s stylo         10,496.02 -> 10,066.22

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=14338