1474905 - Use a dropdown for the state/province field, where possible

Status: VERIFIED FIXED

(Toolkit :: Form Autofill, defect, P1)

Description

[Hani Yacoub, Desktop QA]

[Affected versions]: 
Nightly 63.0a1

[Affected platforms]:
Platforms: Windows 10 x 64, Mac OS X 10.12 and Ubuntu 16.04 x64.

[Steps to reproduce]:
1. In about:config set the pref dom.payments.request.enabled to "true".
2. Go to "https://rsolomakhin.github.io/pr/us/" page and click on "Buy".
3. For FTU flow add shipping address and payment method information by filling all the required fields correctly and make sure state is California and click on "Save".
4. Or in case you have already saved addresses or payment methods.
5. From "Payment method" page click on "add" under "Shipping option" section and fill all the required fields correctly and make sure state is California and click on "Save".

[Expected result]:
"$0.00 Free shipping in California" should be displayed under shipping option ones the state address is California.

[Actual result]:
Adding an address from California isn't reflected on the shipping option.
Under shipping option "$5.00 Standard shipping in US" is displayed instead of "$0.00 Free shipping in California".

Comment 1

[Matthew N. [:MattN]]

Did you have the value "California" in the state field or "CA"? I think you have "California" and that's the issue since we need to return "CA". Can you confirm the problem doesn't happen with a state of "CA"

Comment 2

[Hani Yacoub, Desktop QA]

Yes, I did have the value "California" in the state field. I changed it to "CA" and now it's not reproducible. 
I'll change the status to Invalid.

Comment 3

[Matthew N. [:MattN]]

We can use this bug to track converting to a dropdown for the state/province field.

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

This should use the sub_keys and sub_names properties in addressReferences.js to build the dropdown. The sub_keys will be used for the regionCode and sub_names will be used for the region.

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1474905 - Use a dropdown for the state/province field when possible. r?MattN

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c4d1729c029e
Use a dropdown for the state/province field when possible. r=MattN

Comment 7

[Cosmin Sabou [:CosminS]]

Backed out for browser chrome failures on browser_editCreditCardDialog.js

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&fromchange=c4d1729c029e2c17058c0f093fe9cc0037be0e51&tochange=9e64208641b85674cde06b89592f5ef273a0b02e&searchStr=browser%2Cchrome&group_state=expanded&selectedJob=217078854

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=217078854&repo=autoland&lineNumber=4927

Backout link: https://hg.mozilla.org/integration/autoland/rev/9e64208641b85674cde06b89592f5ef273a0b02e

[task 2018-12-14T19:35:26.079Z] 19:35:26     INFO - TEST-PASS | browser/extensions/formautofill/test/browser/browser_editCreditCardDialog.js | cc-number field should be showing invalid credit card number - 
[task 2018-12-14T19:35:26.080Z] 19:35:26     INFO - Buffered messages finished
[task 2018-12-14T19:35:26.082Z] 19:35:26     INFO - TEST-UNEXPECTED-FAIL | browser/extensions/formautofill/test/browser/browser_editCreditCardDialog.js | save button should be disabled due to invalid credit card number - 
[task 2018-12-14T19:35:26.082Z] 19:35:26     INFO - Stack trace:
[task 2018-12-14T19:35:26.083Z] 19:35:26     INFO - chrome://mochikit/content/browser-test.js:test_ok:1292
[task 2018-12-14T19:35:26.083Z] 19:35:26     INFO - chrome://mochitests/content/browser/browser/extensions/formautofill/test/browser/browser_editCreditCardDialog.js:test_editInvalidCreditCardNumber/<:281
[task 2018-12-14T19:35:26.084Z] 19:35:26     INFO - chrome://mochitests/content/browser/browser/extensions/formautofill/test/browser/head.js:testDialog:361
[task 2018-12-14T19:35:26.084Z] 19:35:26     INFO - chrome://mochitests/content/browser/browser/extensions/formautofill/test/browser/browser_editCreditCardDialog.js:test_editInvalidCreditCardNumber:277
[task 2018-12-14T19:35:26.084Z] 19:35:26     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1093
[task 2018-12-14T19:35:26.085Z] 19:35:26     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1084
[task 2018-12-14T19:35:26.086Z] 19:35:26     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:982
[task 2018-12-14T19:35:26.087Z] 19:35:26     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:803

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1474905 - Don't disable the Save button if the form is empty or not. Instead rely on form validation preventing the Save. r?MattN

Comment 9

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/8d084837f5ee
https://hg.mozilla.org/mozilla-central/rev/99ce4343e015

Comment 10

[Hani Yacoub, Desktop QA]

I confirm that "state/province" field are displayed, where possible (ex. US, CA and AU).
Verified as fixed on Firefox Nightly 66.0a1 on Windows 10 x 64, Mac OS X 10.13 and on Ubuntu 16.04 x64.

Logged Bug 1519081 - "State" field is displayed even after selecting a Country/Region with no list of state/Province