1475162 - Drop dom.animations-api.element-animate.enabled pref

Status: RESOLVED FIXED

(Core :: DOM: Animation, enhancement)

Description

[Brian Birtles (:birtles, Feb 26~ parental leave)]

We've been shipping this since Firefox 48. Although it's occasionally useful to have the pref to see how content behaves without Web Animations, it's not without cost and in particular it makes adding the more fine-grained prefs in bug 1471814 more complex.

Comment 1

[Brian Birtles (:birtles, Feb 26~ parental leave)]

For my own reference, my analysis of all the tests using Web Animations prefs is here:

  https://docs.google.com/spreadsheets/d/1raQF-X4kauoOjQuzP8WJSZwSly6v__kn_xh61_xiX_0/edit?usp=sharing

Comment 2

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Attachment: Bug 1475162 - Drop dom.animations-api.element-animate.enabled pref;

Review commit: https://reviewboard.mozilla.org/r/256470/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/256470/

Comment 3

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Attachment: Bug 1475162 - Drop pref annotations from tests that no longer need them;

Many tests set the dom.animations-api.core.enabled pref to true when all they
really require are the features covered by the dom.element-animate.core.enabled
pref. Now that we have removed that pref and permanently enabled that
functionality we can drop the annotations from such tests.

Review commit: https://reviewboard.mozilla.org/r/256472/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/256472/

Comment 4

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8991555 [details]
Bug 1475162 - Drop pref annotations from tests that no longer need them;

https://reviewboard.mozilla.org/r/256472/#review263352

Nice!

I did just audit files that the pref annotation were removed.  I haven't checked whether there are still tests that the pref can be removed or not.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8991554 [details]
Bug 1475162 - Drop dom.animations-api.element-animate.enabled pref;

https://reviewboard.mozilla.org/r/256470/#review263562

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/00837a12b124
Drop dom.animations-api.element-animate.enabled pref; r=bz
https://hg.mozilla.org/integration/autoland/rev/a4cb46dfbdd7
Drop pref annotations from tests that no longer need them; r=hiro

Comment 7

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/00837a12b124
https://hg.mozilla.org/mozilla-central/rev/a4cb46dfbdd7