1478505 - Add support for CSS prefers-reduced-motion media feature for Android

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P3)

Description

[Hiroyuki Ikezoe (:hiro)]

I think ANIMATOR_DURATION_SCALE is the corresponding setting.

https://developer.android.com/reference/android/provider/Settings.Global#ANIMATOR_DURATION_SCALE

Comment 1

[Hiroyuki Ikezoe (:hiro)]

CCing Android forks.

Note that this bug was filed in 'CSS Parsing and Computation', but all works for this should be done in widget/android and mobile/android.

Comment 2

[Hiroyuki Ikezoe (:hiro)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=796186ff46875c271ac9cb4035381433019e64e3

Detecting ANIMATOR_DURATION_SCALE changes depends on the machinery will be introduced in a patch for bug 1035774.

And an automation test for this will be introduced in bug 1486971.

Comment 3

[Hiroyuki Ikezoe (:hiro)]

D'oh!  I did miss one place to change a variable name.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=92f3d28812da14c621004793919d22735372fbc0

Comment 4

[Hiroyuki Ikezoe (:hiro)]

Hey jchen,  there are two other settings relevant with animations on Android (in Developer options on my phone).

https://developer.android.com/reference/android/provider/Settings.Global.html#TRANSITION_ANIMATION_SCALE
https://developer.android.com/reference/android/provider/Settings.Global.html#WINDOW_ANIMATION_SCALE

It seems to me that those two settings are only for application windows, such as animation effects during switching applications, and not for the contents inside applications, right?  Or should we check all three settings' values are 0?

Comment 5

[(inactive) Jim Chen [:jchen] [:darchons]]

Right, I think it makes more sense to only check ANIMATOR_DURATION_SCALE.

Comment 6

[Hiroyuki Ikezoe (:hiro)]

Great, thanks jchen.  Though dependent bugs haven't landed yet, but those shouldn't affect this bug basically, so I will put patches for this bug on review now.

Comment 7

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1478505 - Rename GeckoInputDeviceListener to GeckoSystemStateListener. r=jchen

Because we are going to use it for prefers-reduced-motion media feature which
is tied to a system setting.

Comment 8

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1478505 - Implement prefers-reduced-motion on Android. r=jchen

Depends on D5502

Comment 9

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1478505 - Run test_mq_prefers_reduced_motion_dynamic.html on Android. r=jchen

To make the test work properly, there needs two functions.  One is just setting
a value for testing and sending the notificaiton for the value changes, the
other one is to reset the state for testing.

The test itself will be introduced in bug 1486971, especially in
https://phabricator.services.mozilla.com/D5004

Depends on D5503

Comment 10

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 9007969 [details]
Bug 1478505 - Rename GeckoInputDeviceListener to GeckoSystemStateListener. r=jchen

Jim Chen [:jchen] [:darchons] has approved the revision.

Comment 11

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 9007970 [details]
Bug 1478505 - Implement prefers-reduced-motion on Android. r=jchen

Jim Chen [:jchen] [:darchons] has approved the revision.

Comment 12

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 9007971 [details]
Bug 1478505 - Run test_mq_prefers_reduced_motion_dynamic.html on Android. r=jchen

Jim Chen [:jchen] [:darchons] has approved the revision.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/239fb18de868
Rename GeckoInputDeviceListener to GeckoSystemStateListener. r=jchen
https://hg.mozilla.org/integration/autoland/rev/aea09f709ef6
Implement prefers-reduced-motion on Android. r=jchen
https://hg.mozilla.org/integration/autoland/rev/759d828c5c2d
Run test_mq_prefers_reduced_motion_dynamic.html on Android. r=jchen

Comment 14

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/239fb18de868
https://hg.mozilla.org/mozilla-central/rev/aea09f709ef6
https://hg.mozilla.org/mozilla-central/rev/759d828c5c2d

Comment 15

[Chris Mills [:cmills]]

Documented — I've submitted a PR to update the compat data:
https://github.com/mdn/browser-compat-data/pull/3080

And added a note to the Fx64 rel notes: 
https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/64#CSS