1479363 - Use JSAutoRealm instead of JSAutoRealmAllowCCW

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement)

Description

[Jan de Mooij [:jandem]]

JSAutoRealmAllowCCW and JSAutoRealm are mostly equivalent, but the latter asserts the object is not a cross-compartment wrapper. JSAutoRealmAllowCCW is deprecated and will go away at some point.

Most places use JSAutoRealmAllowCCW on something that can't be a CCW, so in these cases we can use JSAutoRealm instead. This bug focuses on these easy ones; the rest will be addressed in follow-up bugs.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Part 1 - Use JSAutoRealm instead of JSAutoRealmAllowCCW in dom/base

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Part 2 - Use JSAutoRealm instead of JSAutoRealmAllowCCW in dom/bindings

Comment 3

[Jan de Mooij [:jandem]]

Attachment: Part 3 - Use JSAutoRealm instead of JSAutoRealmAllowCCW in dom/xbl and dom/xul

Comment 4

[Jan de Mooij [:jandem]]

Attachment: Part 4 - Use JSAutoRealm instead of JSAutoRealmAllowCCW in dom/workers and dom/worklet

Comment 5

[Jan de Mooij [:jandem]]

Attachment: Part 5 - Use JSAutoRealm instead of JSAutoRealmAllowCCW in remaining dom/ directories

Comment 6

[Jan de Mooij [:jandem]]

Attachment: Part 6 - Use JSAutoRealm instead of JSAutoRealmAllowCCW in js/xpconnect/loader

Comment 7

[Jan de Mooij [:jandem]]

Attachment: Part 7 - Use JSAutoRealm instead of JSAutoRealmAllowCCW in js/xpconnect/src

Comment 8

[Jan de Mooij [:jandem]]

Attachment: Part 8 - Use JSAutoRealm instead of JSAutoRealmAllowCCW in js/xpconnect/wrapper

Comment 9

[Jan de Mooij [:jandem]]

Attachment: Part 9 - Use JSAutoRealm instead of JSAutoRealmAllowCCW in js/src

Comment 10

[Jan de Mooij [:jandem]]

Attachment: Part 10 - Use JSAutoRealm instead of JSAutoRealmAllowCCW in other directories

Comment 11

[Jan de Mooij [:jandem]]

Attachment: Part 11 - Use JSAutoRealm instead of JSAutoRealmAllowCCW in toolkit/recordreplay/ipc

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a3e06f6ef7c0
part 3 - Use JSAutoRealm instead of JSAutoRealmAllowCCW in dom/xbl and dom/xul. r=bholley
https://hg.mozilla.org/integration/mozilla-inbound/rev/0b27fd1e7ff0
part 4 - Use JSAutoRealm instead of JSAutoRealmAllowCCW in dom/workers and dom/worklet. r=baku
https://hg.mozilla.org/integration/mozilla-inbound/rev/3f6816c00bbb
part 7 - Use JSAutoRealm instead of JSAutoRealmAllowCCW in js/xpconnect/src. r=mrbkap
https://hg.mozilla.org/integration/mozilla-inbound/rev/7655b654db1a
part 8 - Use JSAutoRealm instead of JSAutoRealmAllowCCW in js/xpconnect/wrapper. r=bholley
https://hg.mozilla.org/integration/mozilla-inbound/rev/cf63775518d6
part 9 - Use JSAutoRealm instead of JSAutoRealmAllowCCW in js/src. r=luke
https://hg.mozilla.org/integration/mozilla-inbound/rev/4e35974cdc14
part 11 - Use JSAutoRealm instead of JSAutoRealmAllowCCW in toolkit/recordreplay/ipc. r=bhackett

Comment 13

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/a3e06f6ef7c0
https://hg.mozilla.org/mozilla-central/rev/0b27fd1e7ff0
https://hg.mozilla.org/mozilla-central/rev/3f6816c00bbb
https://hg.mozilla.org/mozilla-central/rev/7655b654db1a
https://hg.mozilla.org/mozilla-central/rev/cf63775518d6
https://hg.mozilla.org/mozilla-central/rev/4e35974cdc14

Comment 14

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8995879 [details] [diff] [review]
Part 1 - Use JSAutoRealm instead of JSAutoRealmAllowCCW in dom/base

>@@ -5659,17 +5659,17 @@ nsGlobalWindowOuter::CallerInnerWindow()

This code is gone on trunk.  Sorry for the bitrot... :(

r=me

Comment 15

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8995880 [details] [diff] [review]
Part 2 - Use JSAutoRealm instead of JSAutoRealmAllowCCW in dom/bindings

r=me

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d96f0a5c7caf
part 1 - Use JSAutoRealm instead of JSAutoRealmAllowCCW in dom/base. r=bz
https://hg.mozilla.org/integration/mozilla-inbound/rev/c630c862f511
part 2 - Use JSAutoRealm instead of JSAutoRealmAllowCCW in dom/bindings. r=bz
https://hg.mozilla.org/integration/mozilla-inbound/rev/1fa4b862e677
part 5 - Use JSAutoRealm instead of JSAutoRealmAllowCCW in remaining dom/ directories. r=mccr8
https://hg.mozilla.org/integration/mozilla-inbound/rev/c459ea4efa8d
part 6 - Use JSAutoRealm instead of JSAutoRealmAllowCCW in js/xpconnect/loader. r=kmag

Comment 17

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 8995890 [details] [diff] [review]
Part 10 - Use JSAutoRealm instead of JSAutoRealmAllowCCW in other directories

Review of attachment 8995890 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the delay. I missed this request.

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f5545b566fd7
part 10 - Use JSAutoRealm instead of JSAutoRealmAllowCCW in other directories. r=mrbkap

Comment 19

[Jan de Mooij [:jandem]]

(In reply to Blake Kaplan (:mrbkap) from comment #17)
> Sorry for the delay. I missed this request.

No worries, I wasn't blocked on it yet.

Thanks for all the reviews.

Comment 20

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/d96f0a5c7caf
https://hg.mozilla.org/mozilla-central/rev/c630c862f511
https://hg.mozilla.org/mozilla-central/rev/1fa4b862e677
https://hg.mozilla.org/mozilla-central/rev/c459ea4efa8d
https://hg.mozilla.org/mozilla-central/rev/f5545b566fd7