1479486 - Can we remove the forward() and home() APIs on windows?

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Boris Zbarsky [:bzbarsky]]

Window.webidl has these three APIs:

  [Throws, ChromeOnly] void back();
  [Throws, ChromeOnly] void forward();
  [Throws, ChromeOnly, NeedsSubjectPrincipal] void home();

According to code coverage, back() is exercised, but forward() and home() are not.  Can we remove them?  Also, could we change the window.back() caller to doing window.history.back() if that's what it really wants to do?

Comment 1

[Dave Townsend [:mossop]]

Yes, we can remove these and change any existing callers of window.back() to window.history.back().

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Remove some unused chromeonly history APIs on Window

Well, back() is used, but only in tests, and those can use history.back().

Comment 3

[Andrew McCreight [:mccr8]]

Comment on attachment 8996191 [details] [diff] [review]
Remove some unused chromeonly history APIs on Window

Review of attachment 8996191 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/nsGlobalWindowOuter.cpp
@@ -4910,5 @@
> -#endif
> -    homeURL = NS_LITERAL_STRING(DEFAULT_HOME_PAGE);
> -  }
> -
> -#ifdef MOZ_PHOENIX

This is a weird ifdef. It is still used in one other place, and is win32 only.

Comment 4

[Boris Zbarsky [:bzbarsky]]

> This is a weird ifdef

Yes, yes, it is.  I filed bug 1479894 on nixing it.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b75e262fac02
Remove some unused chromeonly history APIs on Window.  r=mccr8

Comment 6

[Cristian Brindusan [:cbrindusan]]

Backed out 4 changesets (Bug 1479486, Bug 1479497, Bug 1479475) for build bustages on builds/worker/workspace/build/src/dom/base/nsGlobalWindowInner.cpp:932:53.

https://hg.mozilla.org/integration/mozilla-inbound/rev/2ba660590ac8c71eca40e232dd3c047f5a55250d

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=b75e262fac02c213e2261078bf6c774ec5a5fdf3&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&selectedJob=191245950

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=191245950&repo=mozilla-inbound&lineNumber=19123

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/81eb830da3e6
Remove some unused chromeonly history APIs on Window.  r=mccr8

Comment 8

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/81eb830da3e6

Comment 9

[Eric Shepherd [:sheppy]]

Documentation updated:

https://developer.mozilla.org/en-US/docs/Web/API/Window/back
https://developer.mozilla.org/en-US/docs/Web/API/Window/forward
https://developer.mozilla.org/en-US/docs/Web/API/Window

Noted on Firefox 63 for developers.

Comment 10

[Masatoshi Kimura [:emk]]

(In reply to Eric Shepherd [:sheppy] from comment #9)
> Documentation updated:
> 
> https://developer.mozilla.org/en-US/docs/Web/API/Window/back
> https://developer.mozilla.org/en-US/docs/Web/API/Window/forward
> https://developer.mozilla.org/en-US/docs/Web/API/Window
> 
> Noted on Firefox 63 for developers.

Since these methods were [ChromeOnly], they were removed as a Web API far back (Firefox 31, according to bug 1012944).

Comment 11

[Boris Zbarsky [:bzbarsky]]

I fixed the docs to say Firefox 31.