Closed
Bug 1480195
Opened 6 years ago
Closed 6 years ago
Allow creating custom elements that extend the specialized XUL element classes.
Categories
(DevTools :: DOM, enhancement)
DevTools
DOM
Tracking
(firefox63 fixed)
RESOLVED
FIXED
Firefox 63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: mossop, Assigned: mossop)
References
Details
Attachments
(1 file)
Spinning off from bug 1478139, attempting to convert the <editor> XBL binding to a custom element fails because it must extend XULFrameElement but the code requires XUL elements to only extend XULElement. Normally we'd do this as a custom built-in element, but that would require us to create a custom element that applies to a base <editor> tag with is="". This is solvable by just allowing us to extend the other types. The attached patch does that. It has the downside that the tag names are hardcoded but for our purposes that is fine.
|
Assignee | |
Comment 1•6 years ago
|
||
|
||
Updated•6 years ago
|
Blocks: war-on-xbl
|
||
Comment 2•6 years ago
|
||
Comment on attachment 8996834 [details] Bug 1480195: Allow writing custom element definitions for the special XUL elements. Olli Pettay [:smaug] has approved the revision. https://phabricator.services.mozilla.com/D2430
Attachment #8996834 -
Flags: review+
Pushed by dtownsend@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ebd853eb196e Allow writing custom element definitions for the special XUL elements. r=smaug
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/ebd853eb196e
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
You need to log in
before you can comment on or make changes to this bug.
Description
•