1480798 - Missing RTL support for about:crashes

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[Itiel]

Attachment: Screenshot

This used to be okay a few days ago.
Didn't confirm it with Mozregression but I think bug 1476034 introduced this issue.

See attached.

Comment 1

[Alexis Deschamps [:alexisdeschamps]]

Going to be switching to use https://developer.mozilla.org/en-US/docs/Archive/Themes/Making_sure_your_theme_works_with_RTL_locales instead of the now removed DTD. The implementation will be done in https://bugzilla.mozilla.org/show_bug.cgi?id=1476062.

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

I have a patch that sets the document's directionality in bug 1455649. I'll extract it here

I talked to Alexis on IRC and I'm taking over this bug.

Comment 3

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: Bug 1480798 - Set document's directionality in Fluent. r?stas

Set document's directionality in Fluent.

Comment 4

[Phabricator Automation]

Comment on attachment 8997486 [details]
Bug 1480798 - Set document's directionality in Fluent. r?stas

Staś Małolepszy :stas has approved the revision.

https://phabricator.services.mozilla.com/D2732

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c0bf622859f6
Set document's directionality in Fluent. r=stas

Comment 6

[Cristina Coroiu [:ccoroiu]]

Backed out changeset c0bf622859f6 (bug 1480798) for chrome failures at intl/l10n/test/dom/test_domloc.xul 

Backout: https://hg.mozilla.org/integration/autoland/rev/f20fddf6df089117e5d56fea72e97d0f33fad1a7

Failure push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=c0bf622859f64edad0f259277758bbbe11bb3cbf&selectedJob=191945058

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=191945058&repo=autoland&lineNumber=1840


[task 2018-08-03T20:32:50.954Z] 20:32:50     INFO -  77 INFO TEST-START | intl/l10n/test/dom/test_domloc.xul
[task 2018-08-03T20:37:48.891Z] 20:37:48     INFO -  78 INFO TEST-UNEXPECTED-FAIL | intl/l10n/test/dom/test_domloc.xul | Test timed out.
[task 2018-08-03T20:37:48.891Z] 20:37:48     INFO -  reportError@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:121:7
[task 2018-08-03T20:37:48.891Z] 20:37:48     INFO -  TestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:142:7

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1748bdd2dcaf
Set document's directionality in Fluent. r=stas

Comment 8

[Zibi Braniecki [:zbraniecki][:gandalf]]

A minor tweak to a test.

Comment 9

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/1748bdd2dcaf

Comment 10

[Itiel]

Some elements are still LTR'd on latest Nightly.
Should I file a new bug for that?

Comment 11

[Itiel]

Attachment: LTR elements

Comment 12

[Francesco Lodolo [:flod]]

(In reply to Itiel from comment #10)
> Some elements are still LTR'd on latest Nightly.
> Should I file a new bug for that?

Yes, please. That seems like some CSS in need of fixing.