Closed
Bug 1481393
Opened 6 years ago
Closed 6 years ago
Implement a listener for WebVR PresentationGenerationContext changes
Categories
(Core :: WebVR, enhancement)
Tracking
()
RESOLVED
FIXED
mozilla63
People
(Reporter: mortimergoro, Assigned: mortimergoro)
Details
(Whiteboard: [geckoview:fxr:p1])
Attachments
(1 file)
On FirefoxReality we increate mPresentingGeneration value to exit from WebVR from a back button action. This normally works but I did some tests with webpages that don't call vrDisplay.SubmitFrame and Exit from WebVR didn´t work ok. The problem is that mPresentingGeneration changes are only checked in VRDisplay::SubmitFrame(). We should add a listener dispatch by the watchdog also to protect from situations where vrDisplay.SubmitFrame() is not called.
Assignee | ||
Updated•6 years ago
|
Whiteboard: [geckoview:fxr:p1]
Assignee | ||
Comment 1•6 years ago
|
||
MozReview-Commit-ID: FAR1fYnNM0U
Comment 2•6 years ago
|
||
Since this patch touches dom/base/nsGlobalWindowInner.[h,cpp] you need a peer review. Maybe ehsan?
Assignee: nobody → imanol
Comment 3•6 years ago
|
||
Comment on attachment 8998127 [details] Bug 1481393 - Implement a listener for WebVR PresentationGenerationContext changes; Randall Barker [:rbarker] has approved the revision. https://phabricator.services.mozilla.com/D2832
Attachment #8998127 -
Flags: review+
Comment 4•6 years ago
|
||
Comment on attachment 8998127 [details] Bug 1481393 - Implement a listener for WebVR PresentationGenerationContext changes; :kip (Kearwood Gilbert) has approved the revision. https://phabricator.services.mozilla.com/D2832
Attachment #8998127 -
Flags: review+
Comment 5•6 years ago
|
||
I was told :nika is the correct peer to request the review from.
Comment 6•6 years ago
|
||
Comment on attachment 8998127 [details] Bug 1481393 - Implement a listener for WebVR PresentationGenerationContext changes; :Nika Layzell has approved the revision.
Attachment #8998127 -
Flags: review+
Assignee | ||
Updated•6 years ago
|
Keywords: checkin-needed
Pushed by archaeopteryx@coole-files.de: https://hg.mozilla.org/integration/autoland/rev/56bf1095268f Implement a listener for WebVR PresentationGenerationContext changes; r=kip,rbarker,nika
Keywords: checkin-needed
Comment 8•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/56bf1095268f
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Comment 9•6 years ago
|
||
status-firefox62=wontfix because we don't need to uplift this fix to GV 62 Beta.
status-firefox61:
--- → wontfix
status-firefox62:
--- → wontfix
status-firefox-esr52:
--- → wontfix
status-firefox-esr60:
--- → wontfix
You need to log in
before you can comment on or make changes to this bug.
Description
•