1481949 - Convert <radiogroup> to a Custom Element

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, task, P3)

Description

[Brian Grinstead [:bgrins]]

Once we can implement nsIDOMXULSelectControlElement and nsIDOMXULControlElement (Bug 1478372), this looks like a relatively simple binding to convert:

- https://bgrins.github.io/xbl-analysis/tree/#radiogroup
- Used features: resources (1), property (6), field (1), handler (8), method (6), constructor (1)
- Selectors: radiogroup (content/xul.css)

Comment 1

[Brian Grinstead [:bgrins]]

Attachment: Bug 1481949 - hg cp radio.xml to radio.js

Comment 2

[Brian Grinstead [:bgrins]]

Attachment: Bug 1481949 - Migrate <radiogroup> to a Custom Element;r=timdream

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 9010439 [details]
Bug 1481949 - Migrate <radiogroup> to a Custom Element;r=timdream

Tim Guan-tin Chien [:timdream] (please needinfo) has approved the revision.

Comment 4

[Brian Grinstead [:bgrins]]

Attachment: Bug 1481949 - Don't load Custom Element script files for dummy.xul windows;r=kmag

They are unnecessary for most every element, and we load multiple dummy.xul
documents even in clean profiles.

Comment 5

[Kris Maglione [:kmag]]

Comment on attachment 9012656 [details]
Bug 1481949 - Don't load Custom Element script files for dummy.xul windows;r=kmag

Kris Maglione [:kmag] has approved the revision.

Comment 6

[Brian Grinstead [:bgrins]]

Attachment: Bug 1481949 - Use querySelectorAll instead of a treeWalker for finding radios underneath a radiogroup;r=timdream

This removes support for having a child radiogroup within another radiogroup, but that
behavior is undocumented and unused in tree.

Comment 7

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 9013176 [details]
Bug 1481949 - Use querySelectorAll instead of a treeWalker for finding radios underneath a radiogroup;r=timdream

Tim Guan-tin Chien [:timdream] (please needinfo) has approved the revision.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/96cb7281e630
Don't load Custom Element script files for dummy.xul windows;r=kmag
https://hg.mozilla.org/integration/autoland/rev/b82060ff3299
Migrate <radiogroup> to a Custom Element;r=timdream
https://hg.mozilla.org/integration/autoland/rev/05e791fb2c6b
Use querySelectorAll instead of a treeWalker for finding radios underneath a radiogroup;r=timdream

Comment 9

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/96cb7281e630
https://hg.mozilla.org/mozilla-central/rev/b82060ff3299
https://hg.mozilla.org/mozilla-central/rev/05e791fb2c6b