Closed
Bug 1482200
Opened 6 years ago
Closed 6 years ago
Remove getBoolPref helper function
Categories
(Firefox :: Search, enhancement, P5)
Firefox
Search
Tracking
()
RESOLVED
FIXED
Firefox 63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: mkaply, Assigned: dpino)
Details
(Keywords: good-first-bug)
Attachments
(1 file, 3 obsolete files)
Now that we have pref APIs that take defaults, we should be able to completely remove the getBoolPref helper function in search.
|
Reporter | |
Updated•6 years ago
|
Priority: -- → P5
|
Assignee | |
Comment 1•6 years ago
|
||
I'm attaching a patch. I think it should fix the issue, but maybe I'm missing something.
Attachment #8999946 -
Flags: review?(adw)
|
|
Reporter | |
Comment 2•6 years ago
|
||
This looks great, but one change was made to the nsSearchService recently to remove one part of this patch. Do you mind updating to the latest version of Firefox and reattaching the patch? It should only conflict in one place.
|
||
Comment 3•6 years ago
|
||
Comment on attachment 8999946 [details] [diff] [review] 0001-Remove-getBoolPref-helper-function.patch Review of attachment 8999946 [details] [diff] [review]: ----------------------------------------------------------------- This looks good, but like Mike said (and I'll take his word for it), could you please update the patch based on the latest code? Thanks
Attachment #8999946 -
Flags: review?(adw)
|
|
||
Updated•6 years ago
|
Assignee: nobody → dpino
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 5•6 years ago
|
||
Attachment #9003030 -
Attachment is obsolete: true
Attachment #9003061 -
Flags: review?(adw)
|
|
||
Comment 6•6 years ago
|
||
Comment on attachment 9003061 [details] [diff] [review] Bug-1482200-Remove-getBoolPref-helper-function.patch Review of attachment 9003061 [details] [diff] [review]: ----------------------------------------------------------------- Thank you!
Attachment #9003061 -
Flags: review?(adw) → review+
|
|
Assignee | |
Comment 7•6 years ago
|
||
Added reviewer to commit message.
Attachment #9003061 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•6 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/589011790e72 Remove getBoolPref helper function. r=adw
Keywords: checkin-needed
|
||
Comment 9•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/589011790e72
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
You need to log in
before you can comment on or make changes to this bug.
Description
•