Closed Bug 1482411 Opened 6 years ago Closed 6 years ago

Port bug 1371951 changes to extension-mac.css

Categories

(WebExtensions :: Frontend, enhancement)

enhancement
Not set
normal

Tracking

(firefox63 fixed)

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: ntim, Assigned: e7358d9c)

References

Details

Attachments

(1 file)

Post-reviewing bug 1371951, I noticed browser/components/extensions/extension-mac.css needs to be updated as well.
On it.
Assignee: nobody → e7358d9c
Comment on attachment 8999198 [details]
Bug 1482411 - Port bug 1371951 changes to extension-mac.css

Shane Caraveo (:mixedpuppy) has approved the revision.
Attachment #8999198 - Flags: review+
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/56aaeff290b7
Port bug 1371951 changes to extension-mac.css r=mixedpuppy
https://hg.mozilla.org/mozilla-central/rev/56aaeff290b7
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Can you please add some STRs to this issue(and add a test webextension if possible) or mark the bug as "qe-verify-" ?
(In reply to Victor Carciu from comment #6)
> Can you please add some STRs to this issue(and add a test webextension if
> possible) or mark the bug as "qe-verify-" ?

(In reply to ExE Boss from bug 1371951 comment #61)
> I don’t think it is, as the style changes are covered using automated tests,
> but you can use attachment 8955426 [details] to do a before and after
> comparison in the options page, which has `<input type="checkbox">`
> and `<input type="radio">` in all the possible configurations.
> 
> Without this patch, only the first one works, but with this patch,
> all of them work correctly (see attachment 8956189 [details]).
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: