1482594 - Implement Firefox Monitor popup notification UI

Status: RESOLVED FIXED

(Firefox :: Firefox Monitor, enhancement)

Description

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: WIP

In this bug my goal is to land code for showing a PopupNotification when a breached site is visited.

That includes:
- Code for observing windows and injecting popup notification UI and styles
- Code for triggering a popup notification when needed
- L10n support
- Code to keep this pref'd off

I do NOT plan to cover in THIS bug:
- Fetching actual breach data from HIBP

Comment 1

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Patch

One thing not mentioned in comment 0 is that this patch does not add telemetry yet. I plan to do that in a follow-up.

There are some TODO comments in the code, but they are either not going to be covered in this bug or are minor - so I didn't see any reason not to start getting this reviewed. I've also asked UX a few questions so I may be updating this patch when they respond - but I didn't want to wait for that to get this up.

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ac645faf074f9ff11ac882ce0761f056fa4c4ed1

I will request r? once I have a green try run.

Comment 2

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Patch

Previous patch was broken, fixed and added some improvements.

New try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a196f6ec33c28ce99bced7e00ef32af67a5f8d58

Comment 3

[(inactive) Nihanth Subramanya [:nhnt11]]

This was implemented elsewhere and now lives as a system add-on and is pref'd on after bug 1531838.