Closed
Bug 1483073
Opened 6 years ago
Closed 6 years ago
Remove BrowserOpenSyncTabs and use gSync.openSyncedTabsPanel() instead
Categories
(Firefox :: General, enhancement, P5)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: ntim, Assigned: arshadkazmi42, Mentored)
Details
(Keywords: good-first-bug)
Attachments
(1 file)
I see absolutely no value having this 1 line helper function. In browser-menubar.inc, replace BrowserOpenSyncTabs() with gSync.openSyncedTabsPanel() and in browser.js, remove the BrowserOpenSyncTabs function.
|
||
Comment 1•6 years ago
|
||
Would you be willing to mentor and make this a good-first-bug Tim?
Flags: needinfo?(ntim.bugs)
Priority: -- → P5
|
Reporter | |
Updated•6 years ago
|
Mentor: ntim.bugs
Flags: needinfo?(ntim.bugs)
|
Assignee | |
Comment 2•6 years ago
|
||
Is it open for grab? I am interested to work on it
Flags: needinfo?(ntim.bugs)
|
|
Reporter | |
Comment 3•6 years ago
|
||
(In reply to Arshad Kazmi from comment #2) > Is it open for grab? I am interested to work on it Yes :) Please feel free to open a patch. Let me know if you have any questions.
Assignee: nobody → arshadkazmi42
Flags: needinfo?(ntim.bugs)
|
|
Assignee | |
Comment 4•6 years ago
|
||
|
|
Assignee | |
Comment 5•6 years ago
|
||
Added code to Phrabricator. https://phabricator.services.mozilla.com/D4281 No added any reviewer, whom should I add as reviewer?
Flags: needinfo?(ntim.bugs)
|
|
Assignee | |
Comment 7•6 years ago
|
||
Thanks. Will wait for his feedback
|
||
Comment 8•6 years ago
|
||
Comment on attachment 9003976 [details] Bug 1483073 - Remove BrowserOpenSyncTab() helper function :Gijs (he/him) has approved the revision.
Attachment #9003976 -
Flags: review+
|
||
Updated•6 years ago
|
Attachment #9003976 -
Attachment description: Bug-1483073: Removed BrowserOpenSyncTab() → Bug 1483073 - Remove BrowserOpenSyncTab() helper function
Pushed by ntim.bugs@gmail.com: https://hg.mozilla.org/integration/autoland/rev/7141688c4eca Remove BrowserOpenSyncTab() helper function r=Gijs
|
||
Comment 10•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/7141688c4eca
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
You need to log in
before you can comment on or make changes to this bug.
Description
•