Closed
Bug 1485340
Opened 6 years ago
Closed 6 years ago
URL parsing uses isdigit() and isxdigit()
Categories
(Core :: Networking, defect, P3)
Core
Networking
Tracking
()
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: hsivonen, Assigned: hsivonen)
References
(Blocks 1 open bug)
Details
(Whiteboard: [necko-triaged])
Attachments
(1 file)
Per https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/isdigit-iswdigit-isdigit-l-iswdigit-l these are locale-dependent on Windows and https://stackoverflow.com/questions/2898228/can-isdigit-legitimately-be-locale-dependent-in-c gives an example of how. mozilla::IsAsciiDigit() should be used in place of isdigit() and an analog of isxdigit() needs to be introduced in mfbt/TextUtils.h.
Assignee | ||
Comment 1•6 years ago
|
||
mozilla::IsAsciiHexDigit() is coming in bug 1421501.
Depends on: 1421501
Updated•6 years ago
|
Priority: -- → P3
Whiteboard: [necko-triaged]
Assignee | ||
Comment 2•6 years ago
|
||
MozReview-Commit-ID: 13DUMcZIE19
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → hsivonen
Status: NEW → ASSIGNED
Comment on attachment 9004140 [details] Bug 1485340 - Avoid isdigit() and isxdigit() in URL parsing. Valentin Gosu [:valentin] has approved the revision.
Attachment #9004140 -
Flags: review+
Pushed by hsivonen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/be9a86909487 Avoid isdigit() and isxdigit() in URL parsing. r=valentin
Comment 5•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/be9a86909487
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•