1487246 - Enable ESLint rule no-sequences

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, enhancement)

Description

[Brian Grinstead [:bgrins]]

https://eslint.org/docs/rules/no-sequences

There was a typo in an in-development test that would have gotten caught by this rule and saved some time.

```
await synthesizeKey(LEFT, { shiftKey: true }), "\uF702";
```

Which should have been:

```
await synthesizeKey(LEFT, { shiftKey: true }, "\uF702");
```

https://hg.mozilla.org/try/rev/ed71871c108665d1a07aa46caa3a850eae0f2e54#l2.61

Comment 1

[Dave Townsend [:mossop]]

I ran with this enabled locally and it only flagged 32 errors over the entire tree, seems like we could enable this easily.

Comment 2

[Dave Townsend [:mossop]]

Mostly just mistyped semicolons, only two or three legitimate uses (which I think look clearer removed anyway) and a few actual bugs where folks mistypes "is" as "if".

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8022649ccbfb5ce2bb38cc3192d59f9b90f5d02a

Comment 3

[Dave Townsend [:mossop]]

Attachment: Bug 1487246: Remove uses of comma sequences in linted code. r=Standard8

Two cases were hiding permanently failing tests. I've commented those out and
filed bug 1487431.

Comment 4

[Dave Townsend [:mossop]]

Attachment: Bug 1487246: Enable the eslint no-sequences rule. r=Standard8

Comment 5

[Mark Banner (:standard8)]

Yes, great idea. Anything that helps with finding errors before running any code has my vote.

Comment 6

[Mark Banner (:standard8)]

Comment on attachment 9005226 [details]
Bug 1487246: Remove uses of comma sequences in linted code. r=Standard8

Mark Banner (:standard8) has approved the revision.

Comment 7

[Mark Banner (:standard8)]

Comment on attachment 9005227 [details]
Bug 1487246: Enable the eslint no-sequences rule. r=Standard8

Mark Banner (:standard8) has approved the revision.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2897eaa81db8
Remove uses of comma sequences in linted code. r=Standard8
https://hg.mozilla.org/integration/mozilla-inbound/rev/05e07c98cc36
Enable the eslint no-sequences rule. r=Standard8

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/2897eaa81db8
https://hg.mozilla.org/mozilla-central/rev/05e07c98cc36

Comment 10

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4423

Comment 11

[[github robot]]

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/7226f3cd661adf707ceec4d3306afeff40a173b4
Port Bug 1487246: Enable the eslint no-sequences rule. r=Standard8 (#4423)