1487395 - "Close" button should be displayed instead of "OK" button when payment failed

Status: VERIFIED FIXED

(Firefox :: WebPayments UI, defect, P1)

Description

[Hani Yacoub, Desktop QA]

Affected versions]: 
Nightly 63.0a1

[Affected platforms]:
Platforms: Windows 10 x 64, Mac OS X 10.13 and Ubuntu 18.04 x64.

[Preconditions]:
1. Set the pref dom.payments.request.enabled to "true";
2. Set the pref dom.payments.loglevel to “Debug” to increase the verbosity of console messages.
3. Make sure you have at least one Shipping Address and one payment method saved in your browser (Saved Cards).

[Steps to reproduce]:
1. Go to "https://bug1447777.bmoattachments.org/attachment.cgi?id=8988961" page and click on "Pay(fail)" or "Pay(Timeout)".
2. Select any payment method and click on "Pay" button.

[Expected result]:
- The Failed due to timeout screen is displayed as seen in the spec: https://mozilla.invisionapp.com/share/S5FXRY0D8TZ#/screens/304878933
- "OK" button should be replaced with "Close" button.

[Actual result]:
"OK" button is displayed instead of "Close" button.

Comment 1

[Hani Yacoub, Desktop QA]

Based on the comment from https://bugzilla.mozilla.org/show_bug.cgi?id=1470207#c11 this bug will handle the strings that are displayed to tell the user what went wrong to match the spec(https://mozilla.invisionapp.com/share/S5FXRY0D8TZ#/screens/304878932).

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1487395 - Update strings on error pages, as well as convert apostrophes to use 'smart-quotes'. r?sfoster

Comment 3

[Sam Foster [:sfoster] (he/him)]

The copy for the timeout case suggests 

"The most likely cause is a temporary connection hiccup. Open a new tab to check your network connection or click “Close” to try again." 

However, until the tab-modal dialog is implemented, this will be difficult for the user unless they already have a 2nd window open. Once the payment dialog is open, the user is prevented from interacting with the browser window behind. 

Jared and I discussed this and I think for now we should go ahead and land the existing copy as the plan is to prioritize the tab-modal dialog in M4. If we revise that plan we may want to revisit this.

Comment 4

[Sam Foster [:sfoster] (he/him)]

Also, the text is a little misleading. When this error screen is shown we have already given up on waiting for the complete() call and the request promise has been resolved. So their only option at this point (retry() maybe changes this?) is to close the dialog and cross fingers it works next time.

Comment 5

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 9006657 [details]
Bug 1487395 - Update strings on error pages, as well as convert apostrophes to use 'smart-quotes'. r?sfoster

Sam Foster [:sfoster] has approved the revision.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e9d83a2e788a
Update strings on error pages, as well as convert apostrophes to use 'smart-quotes'. r=sfoster

Comment 7

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/e9d83a2e788a

Comment 8

[Timea Cernea [:tbabos][inactive]]

The error strings, as well as the "Close" button, are looking good on both the Payment Timeout and Failure screen.
However, I would like to point out that the size of the Images, as well as the font of the strings, are different compared to the spec. Check: https://imgur.com/4Lbrlrt
Also, the "Nightly Checkout" is missing from the footer. Should all this be considered as concerns now or it will be handled later?

Comment 9

[Jared Wein [:jaws] (please needinfo? me)]

Sigh... sorry about that. Yeah we should fix both of those. Can you file *another* follow-up for those?

Comment 10

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Timea Babos from comment #8)
> The error strings, as well as the "Close" button, are looking good on both
> the Payment Timeout and Failure screen.
> However, I would like to point out that the size of the Images, as well as
> the font of the strings, are different compared to the spec. Check:
> https://imgur.com/4Lbrlrt
> Also, the "Nightly Checkout" is missing from the footer. Should all this be
> considered as concerns now or it will be handled later?

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #9)
> Sigh... sorry about that. Yeah we should fix both of those. Can you file
> *another* follow-up for those?

I filed https://bugzilla.mozilla.org/show_bug.cgi?id=1489629 for this.

Comment 11

[Timea Cernea [:tbabos][inactive]]

Thanks Jared!

Verified - fixed on the latest Nightly 64.0a1 (2018-09-09) on Windows 10, Mac OS 10.13 and Ubuntu 18.04.
The "Close" button is displayed whenever a payment is failed.