1487763 - [Wayland] Delay scale factor settings when we're missing wl_surface

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Martin Stránský [:stransky] (ni? me)]

Follow up from Bug #1484921

Recently we're missing some windows with this error:
WARNING: WindowSurfaceWayland::Commit(): parent wl_surface is already hidden/deleted.

When a new window is created and it's not shown/mapped yet we can't commit to such window as Wayland refuses so which results to missing popup/tooltip windows.

We need to delay wl_surface_set_buffer_scale() call on such hidden surface.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

We may track the wl_surface_set_buffer_scale() call request by some variable and perform that before wl_surface commit.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1487763 - [Wayland] Set scale factor settings before wl_surface commit, r=jhorak

Comment 3

[Jan Horak [:jhorak]]

Comment on attachment 9006549 [details]
Bug 1487763 - [Wayland] Set scale factor settings before wl_surface commit, r=jhorak

Jan Horak [:jhorak] has approved the revision.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8cad6594aeb9
[Wayland] Set scale factor settings before wl_surface commit, r=jhorak

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/8cad6594aeb9

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Please request Beta approval on this when you're comfortable doing so.

Comment 7

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 9006549 [details]
Bug 1487763 - [Wayland] Set scale factor settings before wl_surface commit, r=jhorak

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1484921
[User impact if declined]: Broken wayland backend on HiDPI displays
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: Distro only code, don't used by mozilla official builds.
[String changes made/needed]: none

Comment 8

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9006549 [details]
Bug 1487763 - [Wayland] Set scale factor settings before wl_surface commit, r=jhorak

Low-risk Wayland patch for Linux, approved for 63 beta 6

Comment 9

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/releases/mozilla-beta/rev/07f61c345475