Closed
Bug 1487785
Opened 6 years ago
Closed 6 years ago
Add pointer: cursor to the [...] badge in the markup view
Categories
(DevTools :: Inspector, enhancement, P3)
DevTools
Inspector
Tracking
(firefox63 fixed)
RESOLVED
FIXED
Firefox 63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: gl, Assigned: fvsch)
Details
Attachments
(4 obsolete files)
No description provided.
|
Reporter | |
Comment 1•6 years ago
|
||
Attachment #9005638 -
Flags: review?(jdescottes)
|
|
Reporter | |
Updated•6 years ago
|
Attachment #9005638 -
Flags: review?(jdescottes)
|
|
Reporter | |
Comment 2•6 years ago
|
||
Attachment #9005638 -
Attachment is obsolete: true
Attachment #9005639 -
Flags: review?(jdescottes)
|
|
Reporter | |
Comment 3•6 years ago
|
||
Attachment #9005639 -
Attachment is obsolete: true
Attachment #9005639 -
Flags: review?(jdescottes)
Attachment #9005642 -
Flags: review?(florens)
|
Assignee | |
Comment 4•6 years ago
|
||
Comment on attachment 9005642 [details] [diff] [review] 1487785.patch Review of attachment 9005642 [details] [diff] [review]: ----------------------------------------------------------------- When hovering the edges of .markup-expand-badge, we only get some of the visual feedback (color changes but not the cursor change). The cursor declaration should go on .markup-expand-badge (size=18×13.5), which already has the click event listener and the :hover style, and not on the smalelr .markup-expand-badge::before (size=14×10).
Attachment #9005642 -
Flags: review?(florens) → review-
|
|
Assignee | |
Comment 5•6 years ago
|
||
|
|
Reporter | |
Comment 6•6 years ago
|
||
Comment on attachment 9005661 [details] Bug 1487785 - Add pointer cursor to expand badge, vertically align badges; r=gl Gabriel [:gl] (ΦωΦ) has approved the revision.
Attachment #9005661 -
Flags: review+
|
|
Reporter | |
Updated•6 years ago
|
Attachment #9005642 -
Attachment is obsolete: true
|
|
Reporter | |
Updated•6 years ago
|
Assignee: gl → florens
Pushed by gabriel.luong@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/5a300e2e1517 Add pointer cursor to expand badge and vertically align badges; r=gl
|
||
Comment 8•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/5a300e2e1517
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
|
||
Updated•5 years ago
|
Attachment #9005661 -
Attachment is obsolete: true
You need to log in
before you can comment on or make changes to this bug.
Description
•