1488788 - Use fluent for about:restartrequired

Status: RESOLVED FIXED

(Firefox :: General, enhancement, P3)

Description

[Jared Wein [:jaws] (please needinfo? me)]

This bug covers converting about:restartrequired (https://searchfox.org/mozilla-central/source/browser/base/content/aboutRestartRequired.xhtml) to Fluent for localization.

Comment 1

[Raza Haider]

Attachment: Bug 1488788 - Migrate about:restartrequired from DTD to Fluent. r?Gijs,jaws,flod

Comment 2

[Raza Haider]

Attachment: Bug 1488788 about:RestartRequired.dtd removed and string translated to the .ftl file. No properties file availabe for change.

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 9007959 [details]
Bug 1488788 - Migrate about:restartrequired from DTD to Fluent. r?Gijs,jaws,flod

Jared Wein [:jaws] (please needinfo? me) has approved the revision.

Comment 4

[:Gijs (he/him)]

Comment on attachment 9007959 [details]
Bug 1488788 - Migrate about:restartrequired from DTD to Fluent. r?Gijs,jaws,flod

:Gijs (he/him) has approved the revision.

Comment 5

[Francesco Lodolo [:flod]]

Comment on attachment 9007959 [details]
Bug 1488788 - Migrate about:restartrequired from DTD to Fluent. r?Gijs,jaws,flod

Francesco Lodolo [:flod] has approved the revision.

Comment 6

[:Gijs (he/him)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/eade7b3002168c6d346aae3ce561aff9d2857968

Comment 7

[:Gijs (he/him)]

Comment on attachment 9007959 [details]
Bug 1488788 - Migrate about:restartrequired from DTD to Fluent. r?Gijs,jaws,flod

:Gijs (he/him) has been removed from the revision.

Comment 8

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b295ff1a58a9
Backed out changeset eade7b300216 for browser_shownRestartRequired.js CS tests failures CLOSED TREE

Comment 9

[Bogdan Tara[:bogdan_tara | bogdant]]

Backed out changeset eade7b300216 for browser_shownRestartRequired.js CS tests failures

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=eade7b3002168c6d346aae3ce561aff9d2857968

Backout link: https://hg.mozilla.org/integration/mozilla-inbound/rev/b295ff1a58a9700eb9fbed49e191124c8becd4aa

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=201275985&repo=mozilla-inbound&lineNumber=1931

[task 2018-09-24T21:13:05.638Z] 21:13:05     INFO - async*onPacket/<@chrome://marionette/content/server.js:246:15
[task 2018-09-24T21:13:05.639Z] 21:13:05     INFO - async*onPacket@chrome://marionette/content/server.js:245:8
[task 2018-09-24T21:13:05.640Z] 21:13:05     INFO - _onJSONObjectReady/<@chrome://marionette/content/transport.js:490:9
[task 2018-09-24T21:13:05.641Z] 21:13:05     INFO - 
[task 2018-09-24T21:13:05.641Z] 21:13:05     INFO - Buffered messages finished
[task 2018-09-24T21:13:05.645Z] 21:13:05     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/tabcrashed/browser_shownRestartRequired.js | Title element exists. - 
[task 2018-09-24T21:13:05.646Z] 21:13:05     INFO - Stack trace:
[task 2018-09-24T21:13:05.646Z] 21:13:05     INFO - chrome://mochitests/content/browser/browser/base/content/test/tabcrashed/browser_shownRestartRequired.js:crashTabTestHelper/<:33
[task 2018-09-24T21:13:05.647Z] 21:13:05     INFO - resource://testing-common/BrowserTestUtils.jsm:withNewTab:111
[task 2018-09-24T21:13:05.649Z] 21:13:05     INFO - chrome://mochitests/content/browser/browser/base/content/test/tabcrashed/browser_shownRestartRequired.js:crashTabTestHelper:17
[task 2018-09-24T21:13:05.649Z] 21:13:05     INFO - chrome://mochitests/content/browser/browser/base/content/test/tabcrashed/browser_shownRestartRequired.js:test_default:47
[task 2018-09-24T21:13:05.650Z] 21:13:05     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1102
[task 2018-09-24T21:13:05.651Z] 21:13:05     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1093
[task 2018-09-24T21:13:05.652Z] 21:13:05     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:995
[task 2018-09-24T21:13:05.655Z] 21:13:05     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:795
[task 2018-09-24T21:13:05.656Z] 21:13:05     INFO - TEST-PASS | browser/base/content/test/tabcrashed/browser_shownRestartRequired.js | Description element exists. - 
[task 2018-09-24T21:13:05.656Z] 21:13:05     INFO - TEST-PASS | browser/base/content/test/tabcrashed/browser_shownRestartRequired.js | Restart button exists. - 
[task 2018-09-24T21:13:05.657Z] 21:13:05     INFO - Leaving test bound test_default
[task 2018-09-24T21:13:05.657Z] 21:13:05     INFO - GECKO(1998) | MEMORY STAT | vsize 633MB | residentFast 275MB | heapAllocated 122MB
[task 2018-09-24T21:13:05.661Z] 21:13:05     INFO - TEST-OK | browser/base/content/test/tabcrashed/browser_shownRestartRequired.js | took 639ms

Comment 10

[Raza Haider]

id = "title" was missing from the title string in the xhtml file. It has been added and will be pushed soon.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6ed1e8303887
Migrate about:restartrequired from DTD to Fluent. r=gijs,jaws,flod

Comment 12

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/6ed1e8303887

Comment 13

[Ton [:Tonnes]]

What’s with the hard return in restart-required-intro?

Comment 14

[:Gijs (he/him)]

(In reply to Ton [:Tonnes] from comment #13)
> What’s with the hard return in restart-required-intro?

Given this is inserted as HTML, I'm pretty sure it makes no difference - it all gets whitespace-collapsed. Please file a separate bug if it's an issue.

Comment 15

[Ton [:Tonnes]]

I guess it’s a typo then and could be handled within this bug.

Comment 16

[:Gijs (he/him)]

(In reply to Ton [:Tonnes] from comment #15)
> I guess it’s a typo then and could be handled within this bug.

No, the bug is closed, and adequately fixed - anything else gets its own bug, even typoes. Bugs are cheap. We only reopen if a fix is wholly inadequate and/or gets backed out, which isn't the case here.

Comment 17

[Raza Haider]

Attachment: Bug 1491680 - Convert strings used in extensions.properties to Fluent