1489375 - Calling resume on a running AudioContext results that the 'sound-playing' icon hides

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P2)

Description

[Rich Jones]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:61.0) Gecko/20100101 Firefox/61.0
Build ID: 20180807170231

Steps to reproduce:

Go to BitMidi.com. Play a MIDI file. Now play another MIDI file. Now play _another_ MIDI file. You will see that the "mute" icon on the tab has disappeared, and right-click-Mute-Tab no longer works. There is now no way to stop the sweet, sweet sound of 90s MIDI.


Actual results:

This has been confirmed by two others: https://news.ycombinator.com/item?id=17931759


Expected results:

This shouldn't happen.

Comment 1

[u554753]

Hi Rich, 

Thanks for reporting this issue.

Reproducible with the following specs:

Version 64.0a1
Build ID: 20180912100128
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv: 64.0) Gecko/20100101 Firefox/64.0

Comment 2

[Andreas Pehrson [:pehrsons]]

Alastor, didn't you work on this? Could you take a look?

P2 for now but feel free to change as appropriate.

Comment 3

[Alastor Wu [:alwu]]

Sure, I will take a look, thanks.

Comment 4

[Alastor Wu [:alwu]]

Attachment: Bug 1489375 - part1 : do not recreate AudioChannelAgent.

When calling resume() on a running AudioContext, there is no need to discard current AudioChannelAgent and then create a new one.

Comment 5

[Alastor Wu [:alwu]]

Attachment: Bug 1489375 - part2 : add test.

add test.

Comment 6

[Paul Adenot (:padenot)]

Comment on attachment 9008870 [details]
Bug 1489375 - part1 : do not recreate AudioChannelAgent.

Paul Adenot (:padenot) has approved the revision.

Comment 7

[Paul Adenot (:padenot)]

Comment on attachment 9008872 [details]
Bug 1489375 - part2 : add test.

Paul Adenot (:padenot) has approved the revision.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6020749b4bd1
part1 : do not recreate AudioChannelAgent. r=padenot

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aca62b00f1e4
part2 : add test. r=padenot

Comment 10

[Alastor Wu [:alwu]]

Uplift reminder.

Comment 11

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/6020749b4bd1
https://hg.mozilla.org/mozilla-central/rev/aca62b00f1e4

Comment 12

[Alastor Wu [:alwu]]

Comment on attachment 9008870 [details]
Bug 1489375 - part1 : do not recreate AudioChannelAgent.

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1195051
[User impact if declined]: The sound indicator won't show anymore 
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: No
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: also uplift patch 2
[Is the change risky?]: No
[Why is the change risky/not risky?]: This patch avoids AudioContext disconnecting with the sound-icon related systems, it only affects icons showing
[String changes made/needed]: No

Comment 13

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9008870 [details]
Bug 1489375 - part1 : do not recreate AudioChannelAgent.

Minimal patch fixing a well defined P2 bug, uplift approved for 63 beta 9, thanks.

Comment 14

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/9bad6b73be9d
https://hg.mozilla.org/releases/mozilla-beta/rev/d63bc2e27b83