Closed Bug 149 Opened 26 years ago Closed

warning fix : ns/nsprpub/pr/src/threads/combined/prulock.c

Categories

(NSPR :: NSPR, defect, P3)

Product:
NSPR
Component:
NSPR
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: rick, Assigned: wtc)

Details

Created by Rick Osborne (rick@rixsoft.com) on Saturday, April 11, 1998 9:50:36 PM PDT
Additional Details :
(In the continuing quest to eliminate even compiler warnings
... )

Ever more compiler directives mucking with variable scopes.
 Didn''t even have to think about this one.

--- prulock.c   Sun Apr 12 00:48:17 1998
+++ prulock.old.c       Wed Apr 08 17:55:09 1998
@@ -206,11 +206,9 @@ extern PRThread *suspendAllThread;
 PR_IMPLEMENT(void) PR_Lock(PRLock *lock)
 {
     PRThread *me = _PR_MD_CURRENT_THREAD();
-#ifndef _PR_GLOBAL_THREADS_ONLY  /* vars not used in that
context */
     PRIntn is;
     PRThread *t;
     PRCList *q;
-#endif

     PR_ASSERT(me != suspendAllThread);
 #if !defined(XP_MAC)
@@ -305,11 +303,9 @@ PR_IMPLEMENT(void) PR_Lock(PRLock
*lock)
 */
 PR_IMPLEMENT(PRStatus) PR_Unlock(PRLock *lock)
 {
-#ifndef _PR_GLOBAL_THREADS_ONLY  /* vars not used in that
context */
     PRCList *q;
     PRThreadPriority pri, boost;
     PRIntn is;
-#endif
     PRThread *me = _PR_MD_CURRENT_THREAD();

     PR_ASSERT(lock->owner == me);
Updated by Wan-Teh Chang (wtc@netscape.com) on Friday, April 24, 1998 12:34:20 PM PDT
Additional Details :
Assigned bug to myself.
per leger, assigning QA contacts to all open bugs without QA contacts according
to list at http://bugzilla.mozilla.org/describecomponents.cgi?product=Browser
Wan-Teh, these are some pretty old bugs. i can't help but assume they have
been fixed by now. If you don't have any objections, i will close out and
verify these bugs in a couple of days: 146, 148, 149, 150, 151, 152, 154
please take corrective action if this is not doing the Right Thing, but,
as it has been a while, i'm marking these fixed and will immediately verify:
bugs 146, 148, 149, 150, 151, 152, 154
Status: RESOLVED → VERIFIED
verified.
NSPR now has its own Bugzilla product.  Moving this bug to the NSPR product.
Commit pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/68cd91e62fda0b1086ef5e098fe59a4da224e66c
Merge pull request #4842 from schalkneethling/issue#149-custom-sizing-classes-for-tabbed-editor-iframe

Add custom sizing classes for tabbed editor
You need to log in before you can comment on or make changes to this bug.