Closed
Bug 1491786
Opened 6 years ago
Closed 6 years ago
_notifyBackgroundTab accesses selectedItem too often
Categories
(Firefox :: Tabbed Browser, enhancement, P3)
Firefox
Tabbed Browser
Tracking
()
RESOLVED
FIXED
Firefox 64
| Tracking | Status | |
|---|---|---|
| firefox64 | --- | fixed |
People
(Reporter: dao, Assigned: maggus.staab)
References
Details
(Keywords: perf)
Attachments
(1 file, 1 obsolete file)
+++ This bug was initially created as a clone of Bug #1491286 +++ The selectedItem getter is kind of expensive, we should only access it once in _notifyBackgroundTab: https://searchfox.org/mozilla-central/rev/99cbc0aec3e1c0b65ff9052523fb5c181b248f57/browser/base/content/tabbrowser.xml#766-767 See the patch in bug 1491286 for how to fix this.
|
Reporter | |
Updated•6 years ago
|
Priority: -- → P3
|
Assignee | |
Comment 1•6 years ago
|
||
is this a good first bug I could work on?
|
|
Reporter | |
Comment 4•6 years ago
|
||
Comment on attachment 9010353 [details] [diff] [review] patch.diff Hm, this looks good at a first glance, but when I try to apply the patch, I get: patch unexpectedly ends in middle of line patch: **** Only garbage was found in the patch input. Did you manually edit the patch file?
Flags: needinfo?(dao+bmo)
|
|
Assignee | |
Comment 5•6 years ago
|
||
I did not manually fiddle with it. But since I got arcanist running I could try to push the patch to phabricator instead. I will try that.
|
|
Assignee | |
Comment 6•6 years ago
|
||
|
|
Assignee | |
Comment 7•6 years ago
|
||
got a phabricator diff up, after a lot or research. thx to the cool people in the #phabricator irc channel (especially imadueme and mcote)
Flags: needinfo?(dao+bmo)
|
|
Assignee | |
Updated•6 years ago
|
Attachment #9010353 -
Attachment is obsolete: true
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/90b5ea4678b3 Access selectedItem only once in _notifyBackgroundTab. r=dao
|
|
Reporter | |
Comment 9•6 years ago
|
||
Comment on attachment 9010427 [details] Bug 1491786 - Access selectedItem only once in _notifyBackgroundTab. r=dao Dão Gottwald [::dao] has approved the revision.
Attachment #9010427 -
Flags: review+
|
|
Reporter | |
Updated•6 years ago
|
Flags: needinfo?(dao+bmo)
|
||
Comment 10•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/90b5ea4678b3
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
You need to log in
before you can comment on or make changes to this bug.
Description
•