1491791 - "Add" button isn't grayed out when adding a wrong card number

Status: VERIFIED FIXED

(Firefox :: WebPayments UI, defect, P1)

Description

[Hani Yacoub, Desktop QA]

Affected versions]: 
Nightly 64.0a1 

[Affected platforms]:
Platforms: Windows 10/7 x64, Ubuntu 18.04, Mac OS 10.13

[Preconditions]:
1. Set the pref dom.payments.request.enabled to "true";
2. Make sure you have at least one Shipping Address and one Credit Card saved in your browser.

[Steps to reproduce]:
1. Go to "https://rsolomakhin.github.io/pr/single/" page and click on "Buy".
2. From "Payments Method" click on "Add".
3. Fill all the fields with correct data but leave "Card Number" empty for now.
4. Enter a valid Card number and observe "Add" button.
5. Add a any number to the card number.
6. Click anywhere and observe "Add" button.


[Expected result]:
"Add" button should be grayed out.

[Actual result]:
- Red outline is displayed all around the field.
- "Add" button isn't grayed out.

Comment 1

[Hani Yacoub, Desktop QA]

Attachment: Add credit card.png

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1491791 - Update the credit card validation as invalid or valid on both change and input events. r?MattN

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1491791 - Update the Save button state after the 'change' event. r?MattN

The validity of the cc-number field is only updated to a failure state after the 'change' event in the EditCreditCard class, but there was no code within basic-card-form.js to update the Save button enabled state after the 'change' event had been handled by EditCreditCard.

Comment 4

[Matthew N. [:MattN]]

Comment on attachment 9010339 [details]
Bug 1491791 - Update the Save button state after the 'change' event. r?MattN

Matthew N. [:MattN] (PM me if requests are blocking you) has approved the revision.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/33a833eab418
Update the Save button state after the 'change' event. r=MattN

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/33a833eab418

Comment 7

[Hani Yacoub, Desktop QA]

Verified as fixed on Firefox Nightly 64.0a1 on Windows 10 x 64, Windows 7 x32, Mac OS X 10.13 and Ubuntu 18.04 x64.