1491850 - restoreSavedBugComment takes a really long time (100ms)

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: User Interface, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

This seems to happen on every tab switch.

Here's a profile of switching between to bugzilla tabs:

https://perfht.ml/2MF5tsl

Comment 1

[Kohei Yoshino [:kohei]]

Looks like some people find it useful that their draft comment is synced between tabs [1] but it’s probably not an expected behaviour for the comment restore functionality, which should be triggered only when the page is loaded. I’d remove the `pageshow` and `focus` event listeners while keeping `DOMContentLoaded`. (I’m not the implementer of the functionality.)

[1] https://twitter.com/kelimuttu/status/1039068104066658304

Comment 2

[Kohei Yoshino [:kohei]]

`pageshow` is fine, `focus` is the culprit.

Comment 3

[Kohei Yoshino [:kohei]]

Attachment: GitHub Pull Request

Comment 4

[Kohei Yoshino [:kohei]]

Merged to master.